Skip to content

Commit 2425f0e

Browse files
authored
Restore PR annotations (#10142)
Our reviewdog annotations stopped appearing some time ago - they've been fixed once, but broken again. This attempts to repair them again, so PRs with minor style issues don't fail, but do have warnings visible for reviewers to easily comment.
1 parent a03d137 commit 2425f0e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/quick-check.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ jobs:
77
build:
88
runs-on: ubuntu-latest
99
strategy:
10+
fail-fast: false
1011
matrix:
1112
java-version: ['11', '17', '21', '22']
1213
steps:
@@ -55,7 +56,7 @@ jobs:
5556
cd gwt
5657
for f in build/out/**/checkstyle*.xml ; do
5758
echo $f
58-
reviewdog -f=checkstyle -filter-mode=diff_context -reporter=github-pr-review -level=info < $f
59+
reviewdog -f=checkstyle -filter-mode=diff_context -reporter=github-pr-annotations -level=info < $f
5960
done
6061
- name: Upload checkstyle xml for manual review
6162
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)