Update, migrate, improve log help links

Fix #10042
See also gwtproject/gwt-site#386

Author: vegegoku

build_tools/doctool/src/com/google/doctool/ResourceIncluder.java

@@ -52,12 +52,29 @@ public static String getResourceFromClasspathScrubbedForHTML(String partialPath)
    */
   private static String getFileFromClassPath(String partialPath)
       throws IOException {
-    try (InputStream in = ResourceIncluder.class.getClassLoader().getResourceAsStream(partialPath);
-    ){
+    InputStream in = ResourceIncluder.class.getClassLoader().getResourceAsStream(
+        partialPath);
+    try {
       if (in == null) {
         throw new FileNotFoundException(partialPath);
       }
-      return new String(in.readAllBytes(), StandardCharsets.UTF_8);
+      ByteArrayOutputStream os = new ByteArrayOutputStream();
+      byte[] buffer = new byte[1024];
+      int bytesRead;
+      while (true) {
+        bytesRead = in.read(buffer);
+        if (bytesRead >= 0) {
+          // Copy the bytes out.
+          os.write(buffer, 0, bytesRead);
+        } else {
+          // End of input stream.
+          break;
+        }
+      }
+
+      return os.toString(StandardCharsets.UTF_8);
+    } finally {
+      close(in);
     }
   }
 

dev/core/src/com/google/gwt/dev/DevMode.java

@@ -30,7 +30,7 @@
 import com.google.gwt.dev.shell.jetty.JettyLauncher;
 import com.google.gwt.dev.ui.RestartServerCallback;
 import com.google.gwt.dev.ui.RestartServerEvent;
-import com.google.gwt.dev.util.InstalledHelpInfo;
+import com.google.gwt.dev.util.GwtprojectOrgHelpInfo;
 import com.google.gwt.dev.util.Util;
 import com.google.gwt.dev.util.arg.ArgHandlerDeployDir;
 import com.google.gwt.dev.util.arg.ArgHandlerExtraDir;
@@ -723,7 +723,7 @@ private void validateServletTags(TreeLogger logger, ServletValidator servletVali
 
     TreeLogger servletLogger =
         logger.branch(TreeLogger.DEBUG, "Validating <servlet> tags for module '" + module.getName()
-            + "'", null, new InstalledHelpInfo("servletMappings.html"));
+            + "'", null, new GwtprojectOrgHelpInfo("/doc/latest/gwt-dev-help/servletMappings.html"));
     for (String servletPath : servletPaths) {
       String servletClass = module.findServletForPath(servletPath);
       assert (servletClass != null);

dev/core/src/com/google/gwt/dev/javac/JSORestrictionsChecker.java

@@ -16,7 +16,7 @@
 package com.google.gwt.dev.javac;
 
 import com.google.gwt.dev.jdt.SafeASTVisitor;
-import com.google.gwt.dev.util.InstalledHelpInfo;
+import com.google.gwt.dev.util.GwtprojectOrgHelpInfo;
 import com.google.gwt.dev.util.collect.Stack;
 
 import org.eclipse.jdt.core.compiler.CharOperation;
@@ -43,16 +43,14 @@
  * Check a compilation unit for violations of
  * {@link com.google.gwt.core.client.JavaScriptObject JavaScriptObject} (JSO)
  * restrictions. The restrictions are summarized in
- * <code>jsoRestrictions.html</code>.
- *
- *
+ * @see <a href="https://www.gwtproject.org/doc/latest/DevGuideCodingBasicsJSNI.html">jsoRestrictions.html</a>.
  * Any violations found are attached as errors on the
  * CompilationUnitDeclaration.
  *
  * @see <a
  *      href="http://code.google.com/p/google-web-toolkit/wiki/OverlayTypes">Overlay
  *      types design doc</a>
- * @see jsoRestrictions.html
+ * @see <a href="https://www.gwtproject.org/doc/latest/DevGuideCodingBasicsJSNI.html">jsoRestrictions.html</a>
  */
 public class JSORestrictionsChecker {
 
@@ -288,8 +286,8 @@ static String errAlreadyImplemented(String intfName, String impl1,
 
   private static void errorOn(ASTNode node, CompilationUnitDeclaration cud,
       String error) {
-    GWTProblem.recordError(node, cud, error, new InstalledHelpInfo(
-        "jsoRestrictions.html"));
+    GWTProblem.recordError(node, cud, error, new GwtprojectOrgHelpInfo(
+        "/doc/latest/DevGuideCodingBasicsJSNI.html"));
   }
 
   private final CompilationUnitDeclaration cud;

dev/core/src/com/google/gwt/dev/javac/JsniReferenceResolver.java

@@ -23,7 +23,7 @@
 import com.google.gwt.dev.js.ast.JsFunction;
 import com.google.gwt.dev.js.ast.JsModVisitor;
 import com.google.gwt.dev.js.ast.JsNameRef;
-import com.google.gwt.dev.util.InstalledHelpInfo;
+import com.google.gwt.dev.util.GwtprojectOrgHelpInfo;
 import com.google.gwt.dev.util.JsniRef;
 import com.google.gwt.dev.util.collect.Stack;
 import com.google.gwt.thirdparty.guava.common.collect.Lists;
@@ -824,8 +824,8 @@ private boolean isUnsafeLongAnnotation(Annotation annot, ClassScope scope) {
   }
 
   private void longAccessError(ASTNode node, String message) {
-    GWTProblem.recordError(node, cud, message, new InstalledHelpInfo(
-        "longJsniRestriction.html"));
+    GWTProblem.recordError(node, cud, message, new GwtprojectOrgHelpInfo(
+        "/doc/latest/gwt-dev-help/longJsniRestriction.html"));
   }
 
   private static void resolveJsniRef(JsniRef jsniRef, FieldBinding fieldBinding) {

dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java

@@ -19,7 +19,7 @@
 import com.google.gwt.core.ext.ServletContainerLauncher;
 import com.google.gwt.core.ext.TreeLogger;
 import com.google.gwt.core.ext.UnableToCompleteException;
-import com.google.gwt.dev.util.InstalledHelpInfo;
+import com.google.gwt.dev.util.GwtprojectOrgHelpInfo;
 import com.google.gwt.dev.util.Util;
 import com.google.gwt.thirdparty.guava.common.collect.Iterators;
 import com.google.gwt.thirdparty.guava.common.collect.Lists;
@@ -447,7 +447,7 @@ private boolean addContainingClassPathEntry(String warnMessage,
         }
         branch = branch.branch(logLevel, "Adding classpath entry '"
             + classPathURL + "' to the web app classpath for this session",
-            null, new InstalledHelpInfo("webAppClassPath.html"));
+            null, new GwtprojectOrgHelpInfo("/doc/latest/gwt-dev-help/webAppClassPath.html"));
         try {
           addClassPath(classPathURL);
           return true;