Skip to content

Tests: DeadCodeEliminationTest.testFloatingPoint() depends on locale setting #10067

@jnehlmeier

Description

@jnehlmeier
Description

DeadCodeEliminationTest.testFloatingPoint() fails if your default locale uses , instead of . in floating point numbers.

I don't like adding -Duser.country=US -Duser.language=en to common.ant.xml -> gwt.junit as I think tests should work without any special configuration, e.g. when running from the IDE directly without ANT.

Instead the test should use String.format(Locale.ENGLISH, ..) when formatting floats to be used as string literals in source code context.

Steps to reproduce

Run ant tests using -Duser.country=DE -Duser.language=de to simulate such a locale setting.

Known workarounds

Run ant tests using -Duser.country=US -Duser.language=en

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions