Deprecate and disable CollectorLegacy, simplify startup #10185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CollectorLegacy shouldn't be needed in any modern browser, though the Error.stack property is still non-standard. This patch leaves it in, so that it is at least possible for projects to restore it if they need it, but won't add an extra step to startup for most GWT applications. With only a single implementation, the static final field isn't needed and likewise doesn't need to be eagerly initialized. This will remove clinits for both Impl and StackTraceCreator everywhere they are used, and by default should still compile out the collector instance into just a set of static functions.
niloc132
added
the
ready
Member
Author
|
Combined compiled size of all examples after this change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CollectorLegacy shouldn't be needed in any modern browser, though the Error.stack property is still non-standard. This patch leaves it in, so that it is at least possible for projects to restore it if they need it, but won't add an extra step to startup for most GWT applications.
With only a single implementation, the static final field isn't needed and likewise doesn't need to be eagerly initialized. This will remove clinits for both Impl and StackTraceCreator everywhere they are used, and by default should still compile out the collector instance into just a set of static functions.