Code quality: strict options turned on; lints used (#241)

Author: gyrdym

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 16.17.2
+- Code quality:
+  - Strict options turned on
+  - Pedantic dependency removed in favour of dart lints package
+
 ## 16.17.1
 - e2e tests:
   - more stable tests for LinearRegressor

analysis_options.yaml

@@ -1,17 +1,21 @@
-include: package:pedantic/analysis_options.yaml
+include: package:lints/core.yaml
 
 linter:
   rules:
     non_constant_identifier_names: false
 
 analyzer:
-  strong-mode:
-    implicit-casts: false
-    implicit-dynamic: true
+  exclude:
+    - test/mocks.mocks.dart
+  language:
+    strict-casts: true
+    strict-inference: true
+    strict-raw-types: true
   errors:
     unnecessary_import: error
     unnecessary_type_check: error
     missing_return: error
     dead_code: error
     duplicate_import: error
     unused_import: error
+    deprecated_member_use_from_same_package: false

benchmark/cross_validator.dart

@@ -36,6 +36,6 @@ class CrossValidatorBenchmark extends BenchmarkBase {
   void tearDown() {}
 }
 
-Future main() async {
+Future<void> main() async {
   CrossValidatorBenchmark.main();
 }

benchmark/decision_tree_classifier.dart

@@ -48,6 +48,6 @@ class DecisionTreeClassifierBenchmark extends BenchmarkBase {
   void tearDown() {}
 }
 
-Future main() async {
+Future<void> main() async {
   DecisionTreeClassifierBenchmark.main();
 }

benchmark/inverse_logit_link_function.dart

@@ -36,6 +36,6 @@ class InverseLogitLinkFunctionBenchmark extends BenchmarkBase {
   void tearDown() {}
 }
 
-Future main() async {
+Future<void> main() async {
   InverseLogitLinkFunctionBenchmark.main();
 }

benchmark/kd_tree/kd_tree_building.dart

@@ -21,7 +21,7 @@ class KDTreeBuildingBenchmark extends BenchmarkBase {
   void tearDown() {}
 }
 
-Future main() async {
+Future<void> main() async {
   final points = Matrix.random(1000, 10, seed: 1, min: -5000, max: 5000);
 
   trainData = DataFrame.fromMatrix(points);

benchmark/kd_tree/kd_tree_querying.dart

@@ -26,7 +26,7 @@ class KDTreeQueryingBenchmark extends BenchmarkBase {
   void tearDown() {}
 }
 
-Future main() async {
+Future<void> main() async {
   final points = Matrix.random(20000, 10, seed: 1, min: -5000, max: 5000);
 
   trainData = DataFrame.fromMatrix(points);

benchmark/knn_regressor.dart

@@ -51,6 +51,6 @@ class KnnRegressorBenchmark extends BenchmarkBase {
   void tearDown() {}
 }
 
-Future main() async {
+Future<void> main() async {
   KnnRegressorBenchmark.main();
 }

benchmark/lasso_regressor.dart

@@ -20,7 +20,7 @@ class LassoRegressorBenchmark extends BenchmarkBase {
   }
 }
 
-Future main() async {
+Future<void> main() async {
   final file = File('benchmark/data/sample_data.json');
   final dataAsString = await file.readAsString();
   final decoded = jsonDecode(dataAsString) as Map<String, dynamic>;

benchmark/linear_regressor.dart

@@ -39,6 +39,6 @@ class LinearRegressorBenchmark extends BenchmarkBase {
   void tearDown() {}
 }
 
-Future main() async {
+Future<void> main() async {
   LinearRegressorBenchmark.main();
 }