Skip to content

Commit c7dcf2d

Browse files
authored
interceptors/urllib3: return version and version_string in response (#176)
>>> import urllib3 >>> resp = urllib3.request("GET", "https://httpbin.org/robots.txt") >>> resp.version 11 >>> resp.version_string 'HTTP/1.1'
1 parent 919dbc0 commit c7dcf2d

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

src/pook/interceptors/urllib3.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,8 @@ def _on_request(
163163
preload_content=False,
164164
reason=http_reasons.get(res._status),
165165
original_response=FakeResponse(method, headers),
166+
version=11,
167+
version_string="HTTP/1.1",
166168
)
167169

168170
def _patch(self, path):

tests/unit/interceptors/urllib3_test.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,3 +106,13 @@ def test_post_with_headers(url_404):
106106
resp = http.request("POST", url_404)
107107
assert resp.status == 200
108108
assert len(mock.matches) == 1
109+
110+
111+
@pytest.mark.pook
112+
def test_sets_version(url_404):
113+
pook.get(url_404).reply(200)
114+
http = urllib3.PoolManager()
115+
resp = http.request("GET", url_404)
116+
assert resp.status == 200
117+
assert resp.version == 11
118+
assert resp.version_string == "HTTP/1.1"

0 commit comments

Comments
 (0)