Skip to content

Commit 43cac9d

Browse files
committed
clean up
1 parent 64236d8 commit 43cac9d

File tree

4 files changed

+0
-35
lines changed

4 files changed

+0
-35
lines changed

src/core/expr/fexpr.cc

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -171,13 +171,6 @@ oobj PyFExpr::m__getitem__(py::robj item) {
171171

172172

173173
//----- Basic arithmetics ------------------------------------------------------
174-
175-
// static oobj make_unexpr(dt::expr::Op op, const PyObject* self) {
176-
// return robj(Expr_Type).call({
177-
// oint(static_cast<int>(op)),
178-
// otuple{oobj(self)}});
179-
// }
180-
181174
static oobj make_binexpr(dt::expr::Op op, robj lhs, robj rhs) {
182175
return robj(Expr_Type).call({
183176
oint(static_cast<int>(op)),
@@ -215,21 +208,6 @@ bool PyFExpr::nb__bool__() {
215208
" f.B != 0\n";
216209
}
217210

218-
// oobj PyFExpr::nb__invert__() {
219-
// return make_unexpr(dt::expr::Op::UINVERT, this);
220-
// }
221-
222-
// oobj PyFExpr::nb__neg__() {
223-
// return make_unexpr(dt::expr::Op::UMINUS, this);
224-
// }
225-
226-
// oobj PyFExpr::nb__pos__() {
227-
// return make_unexpr(dt::expr::Op::UPLUS, this);
228-
// }
229-
230-
231-
232-
233211
//----- Other methods ----------------------------------------------------------
234212

235213
oobj PyFExpr::extend(const XArgs& args) {

src/core/expr/fexpr.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,9 +175,6 @@ class PyFExpr : public py::XObject<PyFExpr> {
175175
static py::oobj nb__lshift__ (py::robj, py::robj);
176176
static py::oobj nb__rshift__ (py::robj, py::robj);
177177
bool nb__bool__();
178-
//py::oobj nb__invert__();
179-
//py::oobj nb__neg__();
180-
//py::oobj nb__pos__();
181178

182179
py::oobj len(); // [DEPRECATED]
183180
py::oobj re_match(const py::XArgs&); // [DEPRECATED]

src/core/expr/funary/umaker.cc

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,6 @@ static const umaker_ptr& get_umaker(Op opcode, SType stype) {
6060
umaker_ptr resolve_op(Op opcode, SType stype)
6161
{
6262
switch (opcode) {
63-
// Basic
64-
case Op::UPLUS: return resolve_op_uplus(stype);
65-
//case Op::UMINUS: return resolve_op_uminus(stype);
66-
//case Op::UINVERT: return resolve_op_uinvert(stype);
67-
6863
// Math: trigonometric
6964
case Op::SIN: return resolve_op_sin(stype);
7065
case Op::COS: return resolve_op_cos(stype);

src/core/expr/funary/umaker.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,11 +81,6 @@ using umaker_ptr = std::unique_ptr<umaker>;
8181
// Main resolver, calls individual-op resolvers below
8282
umaker_ptr resolve_op(Op, SType);
8383

84-
// Basic
85-
umaker_ptr resolve_op_uplus(SType);
86-
//umaker_ptr resolve_op_uminus(SType);
87-
//umaker_ptr resolve_op_uinvert(SType);
88-
8984
// Trigonometric
9085
umaker_ptr resolve_op_sin(SType);
9186
umaker_ptr resolve_op_cos(SType);

0 commit comments

Comments
 (0)