[BREAKING] Refactor NimBLEDevice

* General code cleanup
* `NimBLEDevice::getInitialized` renamed to `NimBLEDevice::isInitialized`.
* `NimBLEDevice::setPower` no longer takes the `esp_power_level_t` and `esp_ble_power_type_t`, instead only an integer value in dbm units is accepted.
* `NimBLEDevice::setPower` now returns a bool value, true = success.
* `NimBLEDevice::setMTU` now returns a bool value, true = success.
* `NimBLEDevice::injectConfirmPIN` renamed to `NimBLEDevice::injectConfirmPasskey` to use Bluetooth naming.
* Fixes crash if `NimBLEDevice::deinit` is called when the stack has not been initialized.
* Reverts 2db4756 as it would cause a crash when the NimBLEServer instance has a connection.

# Conflicts:
#	examples/Refactored_original_examples/BLE_client/BLE_client.ino
#	examples/Refactored_original_examples/BLE_notify/BLE_notify.ino
#	examples/Refactored_original_examples/BLE_uart/BLE_uart.ino
#	src/NimBLEDevice.cpp

Author: h2zero

docs/Migration_guide.md

@@ -386,7 +386,7 @@ The callback methods are:
 > `bool onConfirmPIN(NimBLEConnInfo& connInfo, uint32_t pin)`
 
 Receives the pin when using numeric comparison authentication.
-Call `NimBLEDevice::injectConfirmPIN(connInfo, true);` to accept or `NimBLEDevice::injectConfirmPIN(connInfo, false);` to reject.
+Call `NimBLEDevice::injectConfirmPasskey(connInfo, true);` to accept or `NimBLEDevice::injectConfirmPasskey(connInfo, false);` to reject.
 <br/>
 
 > `void onPassKeyEntry(NimBLEConnInfo& connInfo)`

examples/NimBLE_Client/NimBLE_Client.ino

@@ -67,15 +67,15 @@ class ClientCallbacks : public NimBLEClientCallbacks {
     void onConfirmPIN(NimBLEConnInfo& connInfo, uint32_t pass_key){
         Serial.print("The passkey YES/NO number: ");Serial.println(pass_key);
         /** Inject false if passkeys don't match. */
-        NimBLEDevice::injectConfirmPIN(connInfo, true);
+        NimBLEDevice::injectConfirmPasskey(connInfo, true);
     };
 
     /** Pairing process complete, we can check the results in connInfo */
     void onAuthenticationComplete(NimBLEConnInfo& connInfo){
         if(!connInfo.isEncrypted()) {
             Serial.println("Encrypt connection failed - disconnecting");
             /** Find the client with the connection handle provided in desc */
-            NimBLEDevice::getClientByID(connInfo.getConnHandle())->disconnect();
+            NimBLEDevice::getClientByHandle(connInfo.getConnHandle())->disconnect();
             return;
         }
     }

examples/NimBLE_Server/NimBLE_Server.ino

@@ -48,7 +48,7 @@ class ServerCallbacks: public NimBLEServerCallbacks {
     void onConfirmPIN(NimBLEConnInfo& connInfo, uint32_t pass_key) {
         Serial.print("The passkey YES/NO number: ");Serial.println(pass_key);
         /** Inject false if passkeys don't match. */
-        NimBLEDevice::injectConfirmPIN(connInfo, true);
+        NimBLEDevice::injectConfirmPasskey(connInfo, true);
     };
 
     void onAuthenticationComplete(NimBLEConnInfo& connInfo) {

examples/Refactored_original_examples/BLE_client/BLE_client.ino

@@ -58,7 +58,7 @@ class MyClientCallback : public BLEClientCallbacks {
 
   void onConfirmPIN(const BLEConnInfo& connInfo, uint32_t pass_key) {
     Serial.print("The passkey YES/NO number: ");Serial.println(pass_key);
-    NimBLEDevice::injectConfirmPIN(connInfo, true);
+    NimBLEDevice::injectConfirmPasskey(connInfo, true);
   }
 
   void onAuthenticationComplete(const BLEConnInfo& connInfo){

examples/Refactored_original_examples/BLE_notify/BLE_notify.ino

@@ -65,7 +65,7 @@ class MyServerCallbacks: public BLEServerCallbacks {
     void onConfirmPIN(const BLEConnInfo& connInfo, uint32_t pass_key) {
       Serial.print("The passkey YES/NO number: ");Serial.println(pass_key);
       /** Inject false if passkeys don't match. */
-      NimBLEDevice::injectConfirmPIN(connInfo, true);
+      NimBLEDevice::injectConfirmPasskey(connInfo, true);
     }
 
     void onAuthenticationComplete(const BLEConnInfo& connInfo) {

examples/Refactored_original_examples/BLE_server_multiconnect/BLE_server_multiconnect.ino

@@ -67,7 +67,7 @@ class MyServerCallbacks: public BLEServerCallbacks {
     void onConfirmPIN(const BLEConnInfo& connInfo, uint32_t pass_key) {
       Serial.print("The passkey YES/NO number: ");Serial.println(pass_key);
       /** Inject false if passkeys don't match. */
-      NimBLEDevice::injectConfirmPIN(connInfo, true);
+      NimBLEDevice::injectConfirmPasskey(connInfo, true);
     }
 
     void onAuthenticationComplete(const BLEConnInfo& connInfo) {

examples/Refactored_original_examples/BLE_uart/BLE_uart.ino

@@ -67,7 +67,7 @@ class MyServerCallbacks: public BLEServerCallbacks {
     void onConfirmPIN(const BLEConnInfo& connInfo, uint32_t pass_key) {
       Serial.print("The passkey YES/NO number: ");Serial.println(pass_key);
       /** Inject false if passkeys don't match. */
-      NimBLEDevice::injectConfirmPIN(connInfo, true);
+      NimBLEDevice::injectConfirmPasskey(connInfo, true);
     }
 
     void onAuthenticationComplete(const BLEConnInfo& connInfo) {

src/NimBLEAdvertising.cpp

@@ -44,7 +44,7 @@ NimBLEAdvertising::NimBLEAdvertising() {
  * @brief Stops the current advertising and resets the advertising data to the default values.
  */
 void NimBLEAdvertising::reset() {
-    if(NimBLEDevice::getInitialized() && isAdvertising()) {
+    if(NimBLEDevice::isInitialized() && isAdvertising()) {
         stop();
     }
     memset(&m_advData, 0, sizeof m_advData);
@@ -639,15 +639,15 @@ bool NimBLEAdvertising::start(uint32_t duration, advCompleteCB_t advCompleteCB,
     }
 
 #if defined(CONFIG_BT_NIMBLE_ROLE_PERIPHERAL)
-    rc = ble_gap_adv_start(NimBLEDevice::m_own_addr_type,
+    rc = ble_gap_adv_start(NimBLEDevice::m_ownAddrType,
                            (dirAddr != nullptr) ? dirAddr->getBase() : NULL,
                            duration,
                            &m_advParams,
                            (pServer != nullptr) ? NimBLEServer::handleGapEvent :
                                                   NimBLEAdvertising::handleGapEvent,
                            (void*)this);
 #else
-    rc = ble_gap_adv_start(NimBLEDevice::m_own_addr_type,
+    rc = ble_gap_adv_start(NimBLEDevice::m_ownAddrType,
                            (dirAddr != nullptr) ? &peerAddr : NULL,
                            duration,
                            &m_advParams,

src/NimBLEClient.cpp

@@ -226,7 +226,7 @@ bool NimBLEClient::connect(const NimBLEAddress &address, bool deleteAttributes)
      */
     do {
 #if CONFIG_BT_NIMBLE_EXT_ADV
-        rc = ble_gap_ext_connect(NimBLEDevice::m_own_addr_type,
+        rc = ble_gap_ext_connect(NimBLEDevice::m_ownAddrType,
                                  peerAddr,
                                  m_connectTimeout,
                                  m_phyMask,
@@ -237,7 +237,7 @@ bool NimBLEClient::connect(const NimBLEAddress &address, bool deleteAttributes)
                                  this);
 
 #else
-        rc = ble_gap_connect(NimBLEDevice::m_own_addr_type, peerAddr,
+        rc = ble_gap_connect(NimBLEDevice::m_ownAddrType, peerAddr,
                              m_connectTimeout, &m_pConnParams,
                              NimBLEClient::handleGapEvent, this);
 #endif
@@ -1342,7 +1342,7 @@ void NimBLEClientCallbacks::onIdentity(NimBLEConnInfo& connInfo){
 
 void NimBLEClientCallbacks::onConfirmPIN(NimBLEConnInfo& connInfo, uint32_t pin){
     NIMBLE_LOGD("NimBLEClientCallbacks", "onConfirmPIN: default: true");
-    NimBLEDevice::injectConfirmPIN(connInfo, true);
+    NimBLEDevice::injectConfirmPasskey(connInfo, true);
 }
 
 #endif /* CONFIG_BT_ENABLED && CONFIG_BT_NIMBLE_ROLE_CENTRAL */