Fix incorrect buffer index used when processing longer writes

Roland Szabo · h2zero · commit 7ab51ef3a53a · 2020-08-20T09:45:11.000-06:00
diff --git a/src/NimBLECharacteristic.cpp b/src/NimBLECharacteristic.cpp
@@ -240,7 +240,7 @@ int NimBLECharacteristic::handleGapEvent(uint16_t conn_handle, uint16_t attr_han
                     if((len + next->om_len) > BLE_ATT_ATTR_MAX_LEN) {
                         return BLE_ATT_ERR_INVALID_ATTR_VALUE_LEN;
                     }
-                    memcpy(&buf[len-1], next->om_data, next->om_len);
+                    memcpy(&buf[len], next->om_data, next->om_len);
                     len += next->om_len;
                     next = SLIST_NEXT(next, om_next);
                 }

Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ int NimBLECharacteristic::handleGapEvent(uint16_t conn_handle, uint16_t attr_han`
`240`	`240`	`if((len + next->om_len) > BLE_ATT_ATTR_MAX_LEN) {`
`241`	`241`	`return BLE_ATT_ERR_INVALID_ATTR_VALUE_LEN;`
`242`	`242`	`}`
`243`		`- memcpy(&buf[len-1], next->om_data, next->om_len);`
	`243`	`+ memcpy(&buf[len], next->om_data, next->om_len);`
`244`	`244`	`len += next->om_len;`
`245`	`245`	`next = SLIST_NEXT(next, om_next);`
`246`	`246`	`}`