NimBLEAdvertising: Remove setMin/maxPreferred methods.

* These methods were noop's and are now removed due to lack of usefulness and advertisment space consumed if used.
Applications can still manually set these values if desired using NimBLEAd

Author: h2zero

examples/Refactored_original_examples/BLE_notify/BLE_notify.ino

@@ -116,7 +116,9 @@ void setup() {
   BLEAdvertising *pAdvertising = BLEDevice::getAdvertising();
   pAdvertising->addServiceUUID(SERVICE_UUID);
   pAdvertising->setScanResponse(false);
-  pAdvertising->setMinPreferred(0x0);  // set value to 0x00 to not advertise this parameter
+  /**This method is removed as it was no longer useful and consumed advertising space
+   * pAdvertising->setMinPreferred(0x0);  // set value to 0x00 to not advertise this parameter
+   */
   BLEDevice::startAdvertising();
   Serial.println("Waiting a client connection to notify...");
 }

examples/Refactored_original_examples/BLE_server/BLE_server.ino

@@ -44,8 +44,10 @@ void setup() {
   BLEAdvertising *pAdvertising = BLEDevice::getAdvertising();
   pAdvertising->addServiceUUID(SERVICE_UUID);
   pAdvertising->setScanResponse(true);
-  pAdvertising->setMinPreferred(0x06);  // functions that help with iPhone connections issue
-  pAdvertising->setMinPreferred(0x12);
+  /**These methods are removed as they are no longer useful and consumed advertising space
+  * pAdvertising->setMinPreferred(0x06);  // functions that help with iPhone connections issue
+  * pAdvertising->setMinPreferred(0x12);
+  */
   BLEDevice::startAdvertising();
   Serial.println("Characteristic defined! Now you can read it in your phone!");
 }

examples/Refactored_original_examples/BLE_server_multiconnect/BLE_server_multiconnect.ino

@@ -120,7 +120,9 @@ void setup() {
   BLEAdvertising *pAdvertising = BLEDevice::getAdvertising();
   pAdvertising->addServiceUUID(SERVICE_UUID);
   pAdvertising->setScanResponse(false);
-  pAdvertising->setMinPreferred(0x0);  // set value to 0x00 to not advertise this parameter
+  /**This method is removed it was no longer useful and consumed advertising space
+   * pAdvertising->setMinPreferred(0x0);  // set value to 0x00 to not advertise this parameter
+   */
   BLEDevice::startAdvertising();
   Serial.println("Waiting a client connection to notify...");
 }

src/NimBLEAdvertising.cpp

@@ -136,20 +136,6 @@ void NimBLEAdvertising::setMaxInterval(uint16_t maxinterval) {
 } // setMaxInterval
 
 
-/**
- * @brief NOP - Not yet implemented, dummy function for backward compatibility.
- */
-void NimBLEAdvertising::setMinPreferred(uint16_t mininterval) {
-} // setMinPreferred
-
-
-/**
- * @brief NOP - Not yet implemented, dummy function for backward compatibility.
- */
-void NimBLEAdvertising::setMaxPreferred(uint16_t maxinterval) {
-} // setMaxPreferred
-
-
 /**
  * @brief Set if scan response is available.
  * @param [in] set true = scan response available.

src/NimBLEAdvertising.h

@@ -86,8 +86,6 @@ class NimBLEAdvertising {
     void setAdvertisementData(NimBLEAdvertisementData& advertisementData);
     void setScanFilter(bool scanRequertWhitelistOnly, bool connectWhitelistOnly);
     void setScanResponseData(NimBLEAdvertisementData& advertisementData);
-    void setMinPreferred(uint16_t);
-    void setMaxPreferred(uint16_t);
     void setScanResponse(bool);
 
 private: