Skip to content

Commit b84f333

Browse files
committed
[Bugfix] Add missing config for non-esp devices and adjust values.
1 parent eedb7fa commit b84f333

File tree

2 files changed

+163
-42
lines changed

2 files changed

+163
-42
lines changed

src/nimble/porting/npl/freertos/src/nimble_port_freertos.c

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -98,14 +98,11 @@ nimble_port_freertos_deinit(void)
9898
#else // ESP_PLATFORM
9999

100100
#if NIMBLE_CFG_CONTROLLER
101-
# ifdef MYNEWT_VAL_NIMBLE_CONTROLLER_TASK_STACK_SIZE
102-
# define NIMBLE_LL_STACK_SIZE (MYNEWT_VAL(NIMBLE_CONTROLLER_TASK_STACK_SIZE) / 4)
101+
102+
# if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_EXT_ADV)
103+
# define NIMBLE_LL_STACK_SIZE (MYNEWT_VAL(NIMBLE_CONTROLLER_TASK_STACK_SIZE) / 4) + 30
103104
# else
104-
# if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_EXT_ADV)
105-
# define NIMBLE_LL_STACK_SIZE (130)
106-
# else
107-
# define NIMBLE_LL_STACK_SIZE (100)
108-
# endif
105+
# define NIMBLE_LL_STACK_SIZE (MYNEWT_VAL(NIMBLE_CONTROLLER_TASK_STACK_SIZE) / 4)
109106
# endif
110107

111108
// configMAX_PRIORITIES - 1 is Tmr builtin task

src/syscfg/syscfg.h

Lines changed: 159 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -142,11 +142,15 @@
142142
#endif
143143

144144
#ifndef MYNEWT_VAL_OS_CPUTIME_FREQ
145-
#define MYNEWT_VAL_OS_CPUTIME_FREQ (1000000)
145+
#define MYNEWT_VAL_OS_CPUTIME_FREQ (32768)
146+
#endif
147+
148+
#ifndef MYNEWT_VAL_TIMER_5
149+
#define MYNEWT_VAL_TIMER_5 (1)
146150
#endif
147151

148152
#ifndef MYNEWT_VAL_OS_CPUTIME_TIMER_NUM
149-
#define MYNEWT_VAL_OS_CPUTIME_TIMER_NUM (0)
153+
#define MYNEWT_VAL_OS_CPUTIME_TIMER_NUM (5)
150154
#endif
151155

152156
/* Overridden by @apache-mynewt-core/hw/bsp/native (defined by @apache-mynewt-core/kernel/os) */
@@ -488,7 +492,7 @@
488492

489493
/*** @apache-mynewt-nimble/nimble/host */
490494
#ifndef MYNEWT_VAL_BLE_ATT_PREFERRED_MTU
491-
#define MYNEWT_VAL_BLE_ATT_PREFERRED_MTU (256)
495+
#define MYNEWT_VAL_BLE_ATT_PREFERRED_MTU (517)
492496
#endif
493497

494498
#ifndef MYNEWT_VAL_BLE_ATT_SVR_FIND_INFO
@@ -680,7 +684,7 @@
680684
#endif
681685

682686
#ifndef MYNEWT_VAL_BLE_HS_DEBUG
683-
#define MYNEWT_VAL_BLE_HS_DEBUG (1)
687+
#define MYNEWT_VAL_BLE_HS_DEBUG (0)
684688
#endif
685689

686690
#ifndef MYNEWT_VAL_BLE_HS_FLOW_CTRL
@@ -772,7 +776,7 @@
772776
#endif
773777

774778
#ifndef MYNEWT_VAL_BLE_SM_BONDING
775-
#define MYNEWT_VAL_BLE_SM_BONDING (0)
779+
#define MYNEWT_VAL_BLE_SM_BONDING (1)
776780
#endif
777781

778782
#ifndef MYNEWT_VAL_BLE_SM_IO_CAP
@@ -823,10 +827,6 @@
823827
#define MYNEWT_VAL_BLE_SM_THEIR_KEY_DIST (0)
824828
#endif
825829

826-
#ifndef MYNEWT_VAL_BLE_STORE_CONFIG_PERSIST
827-
#define MYNEWT_VAL_BLE_STORE_CONFIG_PERSIST (1)
828-
#endif
829-
830830
#ifndef MYNEWT_VAL_BLE_STORE_MAX_BONDS
831831
#define MYNEWT_VAL_BLE_STORE_MAX_BONDS (3)
832832
#endif
@@ -839,6 +839,13 @@
839839
#define MYNEWT_VAL_BLE_STORE_MAX_EADS (0)
840840
#endif
841841

842+
#ifndef MYNEWT_VAL_BLE_STORE_CONFIG_PERSIST
843+
#if MYNEWT_VAL_BLE_STORE_MAX_BONDS
844+
#define MYNEWT_VAL_BLE_STORE_CONFIG_PERSIST (1)
845+
#else
846+
#define MYNEWT_VAL_BLE_STORE_CONFIG_PERSIST (0)
847+
#endif
848+
842849
/*** @apache-mynewt-nimble/nimble/host/services/ans */
843850
#ifndef MYNEWT_VAL_BLE_SVC_ANS_NEW_ALERT_CAT
844851
#define MYNEWT_VAL_BLE_SVC_ANS_NEW_ALERT_CAT (0)
@@ -1159,6 +1166,10 @@
11591166
#define MYNEWT_VAL_BLE_MESH_TX_SEG_MSG_COUNT (4)
11601167
#endif
11611168

1169+
#ifndef MYNEWT_VAL_BLE_MESH_SEG_RETRANSMIT_ATTEMPTS
1170+
#define MYNEWT_VAL_BLE_MESH_SEG_RETRANSMIT_ATTEMPTS (4)
1171+
#endif
1172+
11621173
#ifndef MYNEWT_VAL_BLE_SVC_BAS_SYSINIT_STAGE
11631174
#define MYNEWT_VAL_BLE_SVC_BAS_SYSINIT_STAGE (303)
11641175
#endif
@@ -1313,21 +1324,6 @@
13131324
#define MYNEWT_VAL_BLE_SVC_TPS_SYSINIT_STAGE (303)
13141325
#endif
13151326

1316-
/*** @apache-mynewt-nimble/nimble/transport */
1317-
// #undef MYNEWT_VAL_BLE_ACL_BUF_COUNT
1318-
1319-
// #undef MYNEWT_VAL_BLE_ACL_BUF_SIZE
1320-
1321-
// #undef MYNEWT_VAL_BLE_HCI_BRIDGE
1322-
1323-
// #undef MYNEWT_VAL_BLE_HCI_EVT_BUF_SIZE
1324-
1325-
// #undef MYNEWT_VAL_BLE_HCI_EVT_HI_BUF_COUNT
1326-
1327-
// #undef MYNEWT_VAL_BLE_HCI_EVT_LO_BUF_COUNT
1328-
1329-
// #undef MYNEWT_VAL_BLE_HCI_TRANSPORT
1330-
13311327
#ifndef MYNEWT_VAL_BLE_MONITOR_CONSOLE_BUFFER_SIZE
13321328
#define MYNEWT_VAL_BLE_MONITOR_CONSOLE_BUFFER_SIZE (128)
13331329
#endif
@@ -1555,26 +1551,158 @@
15551551
#define MYNEWT_VAL_BLE_LL_WHITELIST_SIZE (12)
15561552
#endif
15571553

1554+
#ifndef MYNEWT_VAL_BLE_LL_PUBLIC_DEV_ADDR
1555+
#define MYNEWT_VAL_BLE_LL_PUBLIC_DEV_ADDR (0x000000000000)
1556+
#endif
1557+
15581558
#ifndef MYNEWT_VAL_BLE_LL_ROLE_BROADCASTER
1559-
#define MYNEWT_VAL_BLE_LL_ROLE_BROADCASTER MYNEWT_VAL_BLE_ROLE_BROADCASTER
1559+
#define MYNEWT_VAL_BLE_LL_ROLE_BROADCASTER MYNEWT_VAL(BLE_ROLE_BROADCASTER)
15601560
#endif
15611561

15621562
#ifndef MYNEWT_VAL_BLE_LL_ROLE_CENTRAL
1563-
#define MYNEWT_VAL_BLE_LL_ROLE_CENTRAL MYNEWT_VAL_BLE_ROLE_CENTRAL
1563+
#define MYNEWT_VAL_BLE_LL_ROLE_CENTRAL MYNEWT_VAL(BLE_ROLE_CENTRAL)
15641564
#endif
15651565

15661566
#ifndef MYNEWT_VAL_BLE_LL_ROLE_OBSERVER
1567-
#define MYNEWT_VAL_BLE_LL_ROLE_OBSERVER MYNEWT_VAL_BLE_ROLE_OBSERVER
1567+
#define MYNEWT_VAL_BLE_LL_ROLE_OBSERVER MYNEWT_VAL(BLE_ROLE_OBSERVER)
15681568
#endif
15691569

15701570
#ifndef MYNEWT_VAL_BLE_LL_ROLE_PERIPHERAL
1571-
#define MYNEWT_VAL_BLE_LL_ROLE_PERIPHERAL MYNEWT_VAL_BLE_ROLE_PERIPHERAL
1571+
#define MYNEWT_VAL_BLE_LL_ROLE_PERIPHERAL MYNEWT_VAL(BLE_ROLE_PERIPHERAL)
1572+
#endif
1573+
1574+
#ifndef MYNEWT_VAL_BLE_LL_CFG_FEAT_CONN_PARAM_REQ
1575+
#define MYNEWT_VAL_BLE_LL_CFG_FEAT_CONN_PARAM_REQ (1)
1576+
#endif
1577+
1578+
#ifndef MYNEWT_VAL_BLE_LL_SCA
1579+
#define MYNEWT_VAL_BLE_LL_SCA (60)
1580+
#endif
1581+
1582+
#ifndef MYNEWT_VAL_BLE_LL_CFG_FEAT_PERIPH_INIT_FEAT_XCHG
1583+
#define MYNEWT_VAL_BLE_LL_CFG_FEAT_PERIPH_INIT_FEAT_XCHG (1)
1584+
#endif
1585+
1586+
#ifndef MYNEWT_VAL_BLE_LL_CONN_INIT_MIN_WIN_OFFSET
1587+
#define MYNEWT_VAL_BLE_LL_CONN_INIT_MIN_WIN_OFFSET (0)
1588+
#endif
1589+
1590+
#ifndef MYNEWT_VAL_BLE_LL_CONN_INIT_SLOTS
1591+
#define MYNEWT_VAL_BLE_LL_CONN_INIT_SLOTS (4)
1592+
#endif
1593+
1594+
#ifndef MYNEWT_VAL_BLE_LL_DTM
1595+
#define MYNEWT_VAL_BLE_LL_DTM (0)
1596+
#endif
1597+
1598+
#ifndef MYNEWT_VAL_BLE_LL_NUM_COMP_PKT_ITVL_MS
1599+
#define MYNEWT_VAL_BLE_LL_NUM_COMP_PKT_ITVL_MS (2000)
15721600
#endif
15731601

15741602
#ifndef MYNEWT_VAL_BLE_LL_TX_PWR_MAX_DBM
15751603
#define MYNEWT_VAL_BLE_LL_TX_PWR_MAX_DBM (20)
15761604
#endif
15771605

1606+
#ifndef MYNEWT_VAL_BLE_HW_WHITELIST_ENABLE
1607+
#define MYNEWT_VAL_BLE_HW_WHITELIST_ENABLE (1)
1608+
#endif
1609+
1610+
#ifndef MYNEWT_VAL_BLE_LL_CONN_STRICT_SCHED
1611+
#define MYNEWT_VAL_BLE_LL_CONN_STRICT_SCHED (0)
1612+
#endif
1613+
1614+
#ifndef MYNEWT_VAL_BLE_LL_CFG_FEAT_DATA_LEN_EXT
1615+
#define MYNEWT_VAL_BLE_LL_CFG_FEAT_DATA_LEN_EXT (MYNEWT_VAL(BLE_ROLE_PERIPHERAL) || MYNEWT_VAL(BLE_ROLE_CENTRAL))
1616+
#endif
1617+
1618+
#ifndef MYNEWT_VAL_BLE_LL_CFG_FEAT_LE_ENCRYPTION
1619+
#define MYNEWT_VAL_BLE_LL_CFG_FEAT_LE_ENCRYPTION (MYNEWT_VAL(BLE_ROLE_PERIPHERAL) || MYNEWT_VAL(BLE_ROLE_CENTRAL))
1620+
#endif
1621+
1622+
#ifndef MYNEWT_VAL_BLE_LL_CFG_FEAT_LE_CSA2
1623+
#define MYNEWT_VAL_BLE_LL_CFG_FEAT_LE_CSA2 (1)
1624+
#endif
1625+
1626+
#ifndef MYNEWT_VAL_BLE_LL_CFG_FEAT_LE_PING
1627+
#define MYNEWT_VAL_BLE_LL_CFG_FEAT_LE_PING (0)
1628+
#endif
1629+
1630+
#ifndef MYNEWT_VAL_BLE_LL_CFG_FEAT_LL_EXT_ADV
1631+
#define MYNEWT_VAL_BLE_LL_CFG_FEAT_LL_EXT_ADV (MYNEWT_VAL_BLE_EXT_ADV)
1632+
#endif
1633+
1634+
#ifndef MYNEWT_VAL_BLE_LL_CONN_INIT_MAX_TX_BYTES
1635+
#define MYNEWT_VAL_BLE_LL_CONN_INIT_MAX_TX_BYTES (27)
1636+
#endif
1637+
1638+
#ifndef MYNEWT_VAL_BLE_LL_MAX_PKT_SIZE
1639+
#define MYNEWT_VAL_BLE_LL_MAX_PKT_SIZE (251)
1640+
#endif
1641+
1642+
#ifndef MYNEWT_VAL_BLE_LL_SUPP_MAX_RX_BYTES
1643+
#define MYNEWT_VAL_BLE_LL_SUPP_MAX_RX_BYTES (MYNEWT_VAL(BLE_LL_MAX_PKT_SIZE))
1644+
#endif
1645+
1646+
#ifndef MYNEWT_VAL_BLE_LL_SUPP_MAX_TX_BYTES
1647+
#define MYNEWT_VAL_BLE_LL_SUPP_MAX_TX_BYTES (MYNEWT_VAL(BLE_LL_MAX_PKT_SIZE))
1648+
#endif
1649+
1650+
#ifndef MYNEWT_VAL_BLE_LL_NUM_SCAN_DUP_ADVS
1651+
#define MYNEWT_VAL_BLE_LL_NUM_SCAN_DUP_ADVS (32)
1652+
#endif
1653+
1654+
#ifndef MYNEWT_VAL_BLE_LL_NUM_SCAN_RSP_ADVS
1655+
#define MYNEWT_VAL_BLE_LL_NUM_SCAN_RSP_ADVS (32)
1656+
#endif
1657+
1658+
#ifndef MYNEWT_VAL_BLE_LL_MANUFACTURER_ID
1659+
#define MYNEWT_VAL_BLE_LL_MANUFACTURER_ID (0x0b65)
1660+
#endif
1661+
1662+
#ifndef MYNEWT_VAL_BLE_LL_RESOLV_LIST_SIZE
1663+
#if MYNEWT_VAL(BLE_STORE_MAX_BONDS)
1664+
#define MYNEWT_VAL_BLE_LL_RESOLV_LIST_SIZE (4)
1665+
#else
1666+
#define MYNEWT_VAL_BLE_LL_RESOLV_LIST_SIZE (0)
1667+
#endif
1668+
#endif
1669+
1670+
#ifndef MYNEWT_VAL_BLE_LL_RNG_BUFSIZE
1671+
#define MYNEWT_VAL_BLE_LL_RNG_BUFSIZE (32)
1672+
#endif
1673+
1674+
#ifndef MYNEWT_VAL_BLE_LL_TX_PWR_DBM
1675+
#define MYNEWT_VAL_BLE_LL_TX_PWR_DBM (0)
1676+
#endif
1677+
1678+
#ifndef MYNEWT_VAL_BLE_LL_SYSVIEW
1679+
#define MYNEWT_VAL_BLE_LL_SYSVIEW (0)
1680+
#endif
1681+
1682+
#ifndef MYNEWT_VAL_BLE_LL_HCI_VS_EVENT_ON_ASSERT
1683+
#define MYNEWT_VAL_BLE_LL_HCI_VS_EVENT_ON_ASSERT (0)
1684+
#endif
1685+
1686+
#ifndef MYNEWT_VAL_BLE_LL_SCHED_AUX_MAFS_DELAY
1687+
#define MYNEWT_VAL_BLE_LL_SCHED_AUX_MAFS_DELAY (0)
1688+
#endif
1689+
1690+
#ifndef MYNEWT_VAL_BLE_LL_SCHED_AUX_CHAIN_MAFS_DELAY
1691+
#define MYNEWT_VAL_BLE_LL_SCHED_AUX_CHAIN_MAFS_DELAY (0)
1692+
#endif
1693+
1694+
#ifndef MYNEWT_VAL_BLE_LL_SCHED_SCAN_AUX_PDU_LEN
1695+
#define MYNEWT_VAL_BLE_LL_SCHED_SCAN_AUX_PDU_LEN (41)
1696+
#endif
1697+
1698+
#ifndef MYNEWT_VAL_BLE_LL_SCHED_SCAN_SYNC_PDU_LEN
1699+
#define MYNEWT_VAL_BLE_LL_SCHED_SCAN_SYNC_PDU_LEN (32)
1700+
#endif
1701+
1702+
#ifndef MYNEWT_VAL_BLE_LL_RFMGMT_ENABLE_TIME
1703+
#define MYNEWT_VAL_BLE_LL_RFMGMT_ENABLE_TIME (1500)
1704+
#endif
1705+
15781706
#ifndef MYNEWT_VAL_BLE_MESH_NET_BUF_USER_DATA_SIZE
15791707
#define MYNEWT_VAL_BLE_MESH_NET_BUF_USER_DATA_SIZE (4)
15801708
#endif
@@ -1729,10 +1857,6 @@
17291857
#define MYNEWT_VAL_BLE_LL_CFG_FEAT_LL_PRIVACY (1)
17301858
#endif
17311859

1732-
#ifndef MYNEWT_VAL_BLE_LL_CFG_FEAT_LL_EXT_ADV
1733-
#define MYNEWT_VAL_BLE_LL_CFG_FEAT_LL_EXT_ADV (MYNEWT_VAL_BLE_EXT_ADV)
1734-
#endif
1735-
17361860
#ifndef MYNEWT_VAL_BLE_MESH_PROVISIONER
17371861
#define MYNEWT_VAL_BLE_MESH_PROVISIONER (0)
17381862
#endif
@@ -1746,7 +1870,7 @@
17461870
#endif
17471871

17481872
#ifndef MYNEWT_VAL_BLE_USE_ESP_TIMER
1749-
#define MYNEWT_VAL_BLE_USE_ESP_TIMER (1)
1873+
#define MYNEWT_VAL_BLE_USE_ESP_TIMER (0)
17501874
#endif
17511875

17521876
#ifndef MYNEWT_VAL_OPTIMIZE_MULTI_CONN
@@ -1823,11 +1947,11 @@
18231947
#endif
18241948
#endif
18251949

1826-
#define BLE_50_FEATURE_SUPPORT (1)
1950+
#define BLE_50_FEATURE_SUPPORT (MYNEWT_VAL_BLE_LL_CFG_FEAT_DATA_LEN_EXT)
18271951

18281952
/* NimBLE-Arduino added configurations */
18291953
#ifndef MYNEWT_VAL_NIMBLE_CONTROLLER_TASK_STACK_SIZE
1830-
#define MYNEWT_VAL_NIMBLE_CONTROLLER_TASK_STACK_SIZE (4096)
1954+
#define MYNEWT_VAL_NIMBLE_CONTROLLER_TASK_STACK_SIZE (440)
18311955
#endif
18321956

18331957
#ifndef MYNEWT_VAL_NIMBLE_CPP_FREERTOS_TASK_BLOCK_BIT

0 commit comments

Comments
 (0)