Release 1.2.0

Author: h2zero

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 All notable changes to this project will be documented in this file.  
 
-## [Unreleased]
+## [1.2.0] - 2021-02-08
 
 ### Added
 - `NimBLECharacteristic::getDescriptorByHandle`: Return the BLE Descriptor for the given handle.
@@ -47,11 +47,15 @@ Overloads to get a vector containing pointers to all the characteristics in a se
   - `haveTargetAddress/getTargetAddressCount/getTargetAddress(index)`: checks if a target address is present / gets a count of the addresses targeted / gets the address of the target at index.
 
 ### Changed
+- `nimconfig.h` (Arduino) is now easier to use.
+
 - `NimBLEServer::getServiceByUUID` Now takes an extra parameter of instanceID to support multiple services with the same UUID.
 
 - `NimBLEService::getCharacteristic` Now takes an extra parameter of instanceID to support multiple characteristics with the same UUID.
 
-- `NimBLEAdvertising` Transmission power is no longer advertised by default and can be added to the advertisement by calling `NimBLEAdvertising::addTxPower`  
+- `NimBLEAdvertising` Transmission power is no longer advertised by default and can be added to the advertisement by calling `NimBLEAdvertising::addTxPower`
+
+- `NimBLEAdvertising` Custom scan response data can now be used without custom advertisment.
 
 - `NimBLEScan` Now uses the controller duplicate filter.  
 

docs/Command_line_config.md

@@ -1,93 +1,117 @@
 # Arduino command line and platformio config options  
 
-`CONFIG_BT_NIMBLE_ROLE_CENTRAL_DISABLED`  
- 
- If defined, NimBLE Client functions will not be included.  
-- Reduces flash size by approx. 7kB.  
-<br>
-
-`CONFIG_BT_NIMBLE_ROLE_OBSERVER_DISABLED`    
+`CONFIG_BT_NIMBLE_MAX_CONNECTIONS`  
 
-If defined, NimBLE Scan functions will not be included.  
-- Reduces flash size by approx. 26kB.  
-<br>
+Sets the number of simultaneous connections (esp controller max is 9)  
+- Default value is 3  
+<br/>
 
-`CONFIG_BT_NIMBLE_ROLE_PERIPHERAL_DISABLED`   
+`CONFIG_BT_NIMBLE_ATT_PREFERRED_MTU`  
 
-If defined NimBLE Server functions will not be included.  
-- Reduces flash size by approx. 16kB.  
-<br>
+Sets the default MTU size.  
+- Default value is 255  
+<br/>
 
-`CONFIG_BT_NIMBLE_ROLE_BROADCASTER_DISABLED`    
+`CONFIG_BT_NIMBLE_SVC_GAP_DEVICE_NAME`  
 
-If defined, NimBLE Advertising functions will not be included.  
-- Reduces flash size by approx. 5kB.  
-<br>
+Set the default device name  
+- Default value is "nimble"  
+<br/>
 
 `CONFIG_BT_NIMBLE_DEBUG`   
 
 If defined, enables debug log messages from the NimBLE host  
 - Uses approx. 32kB of flash memory.  
-<br> 
+<br/>
 
 `CONFIG_NIMBLE_CPP_ENABLE_RETURN_CODE_TEXT`  
 
 If defined, NimBLE host return codes will be printed as text in debug log messages.  
 - Uses approx. 7kB of flash memory.  
-<br>  
+<br/>
 
 `CONFIG_NIMBLE_CPP_ENABLE_GAP_EVENT_CODE_TEXT`  
 
 If defined, GAP event codes will be printed as text in debug log messages.  
 - Uses approx. 1kB of flash memory.  
-<br>
+<br/>
 
 `CONFIG_NIMBLE_CPP_ENABLE_ADVERTISMENT_TYPE_TEXT`  
 
 If defined, advertisment types will be printed as text while scanning in debug log messages.  
 - Uses approx. 250 bytes of flash memory.  
-<br>  
+<br/>
 
-`CONFIG_BT_NIMBLE_PINNED_TO_CORE`  
+`CONFIG_BT_NIMBLE_SVC_GAP_APPEARANCE`  
 
-Sets the core the NimBLE host stack will run on   
-- Options: 0 or 1
-<br>
+Set the default appearance.  
+- Default value is 0x00  
+<br/>
 
-`CONFIG_BT_NIMBLE_TASK_STACK_SIZE`  
+`CONFIG_BT_NIMBLE_ROLE_CENTRAL_DISABLED`  
+ 
+If defined, NimBLE Client functions will not be included.  
+- Reduces flash size by approx. 7kB.  
+<br/>
 
-Set the task stack size for the NimBLE core.
-- Default is 4096  
-<br>
+`CONFIG_BT_NIMBLE_ROLE_OBSERVER_DISABLED`  
 
+If defined, NimBLE Scan functions will not be included.  
+- Reduces flash size by approx. 26kB.  
+<br/>
 
-`CONFIG_BT_NIMBLE_MEM_ALLOC_MODE_EXTERNAL`
+`CONFIG_BT_NIMBLE_ROLE_PERIPHERAL_DISABLED`  
 
-Sets the NimBLE stack to use external PSRAM will be loaded  
-- Must be defined with a value of 1; Default is CONFIG_BT_NIMBLE_MEM_ALLOC_MODE_INTERNAL 1  
-<br>
+If defined NimBLE Server functions will not be included.  
+- Reduces flash size by approx. 16kB.  
+<br/>
 
-`CONFIG_BT_NIMBLE_MAX_CONNECTIONS`
+`CONFIG_BT_NIMBLE_ROLE_BROADCASTER_DISABLED`  
 
-Sets the number of simultaneous connections (esp controller max is 9)  
-- Default value is 3  
-<br>
- 
-`CONFIG_BT_NIMBLE_MAX_BONDS`
+If defined, NimBLE Advertising functions will not be included.  
+- Reduces flash size by approx. 5kB.  
+<br/>
+
+`CONFIG_BT_NIMBLE_MAX_BONDS`  
 
 Sets the number of devices allowed to store/bond with  
 - Default value is 3  
-<br>
+<br/>
 
-`CONFIG_BT_NIMBLE_MAX_CCCDS` 
+`CONFIG_BT_NIMBLE_MAX_CCCDS`  
 
 Sets the maximum number of CCCD subscriptions to store  
 - Default value is 8  
-<br>
- 
-`CONFIG_BT_NIMBLE_SVC_GAP_DEVICE_NAME`  
+<br/>
 
-Set the default device name  
-- Default value is "nimble"  
-<br>
+`CONFIG_BT_NIMBLE_RPA_TIMEOUT`  
+
+Sets the random address refresh time in seconds.  
+- Default value is 900  
+<br/>
+
+`CONFIG_BT_NIMBLE_MSYS1_BLOCK_COUNT`  
+
+Set the number of msys blocks For prepare write & prepare responses. This may need to be increased if  
+you are sending large blocks of data with a low MTU. E.g: 512 bytes with 23 MTU will fail.  
+- Default value is 12  
+<br/>
+
+`CONFIG_BT_NIMBLE_MEM_ALLOC_MODE_EXTERNAL`  
+
+Sets the NimBLE stack to use external PSRAM will be loaded  
+- Must be defined with a value of 1; Default is CONFIG_BT_NIMBLE_MEM_ALLOC_MODE_INTERNAL 1  
+<br/>
+
+`CONFIG_BT_NIMBLE_PINNED_TO_CORE`  
+
+Sets the core the NimBLE host stack will run on   
+- Options: 0 or 1
+<br/>
+
+`CONFIG_BT_NIMBLE_TASK_STACK_SIZE`  
+
+Set the task stack size for the NimBLE core.  
+- Default is 4096  
+<br/>
 

docs/Migration_guide.md

@@ -220,10 +220,11 @@ If you wish to advertise these parameters you can still do so manually via `BLEA
 <br/>
 
 Calling `NimBLEAdvertising::setAdvertisementData` will entirely replace any data set with `NimBLEAdvertising::addServiceUUID`, or  
-`NimBLEAdvertising::setAppearance`. You should set all the data you wish to advertise within the `NimBLEAdvertisementData` instead.  
+`NimBLEAdvertising::setAppearance` or similar methods. You should set all the data you wish to advertise within the `NimBLEAdvertisementData` instead.  
 
-Calling `NimBLEAdvertising::setScanResponseData` without also calling `NimBLEAdvertising::setAdvertisementData` will have no effect.  
-When using custom scan response data you must also use custom advertisement data.  
+~~Calling `NimBLEAdvertising::setScanResponseData` without also calling `NimBLEAdvertising::setAdvertisementData` will have no effect.  
+When using custom scan response data you must also use custom advertisement data.~~  
+No longer true as of release 1.2.0 and above, custom scan response is now supported without custom advertisement data.  
 <br/>
 
 > BLEAdvertising::start (NimBLEAdvertising::start)

examples/NimBLE_Service_Data_Advertiser/NimBLE_Service_Data_Advertiser.ino

@@ -30,4 +30,4 @@ void loop() {
   Serial.printf("Advertising count = %d\n", count);
   count++;
   delay(5000);
-}
+}

library.properties

@@ -1,5 +1,5 @@
 name=NimBLE-Arduino
-version=1.1.0
+version=1.2.0
 author=h2zero
 maintainer=h2zero <[email protected]>
 sentence=Bluetooth low energy (BLE) library for arduino-esp32 based on NimBLE.

src/NimBLEAdvertising.cpp

@@ -142,7 +142,7 @@ void NimBLEAdvertising::setName(const std::string &name) {
 
 /**
  * @brief Set the advertised manufacturer data.
- * @param [in] name The data to advertise.
+ * @param [in] data The data to advertise.
  */
 void NimBLEAdvertising::setManufacturerData(const std::string &data) {
     m_mfgData.assign(data.begin(), data.end());
@@ -154,7 +154,7 @@ void NimBLEAdvertising::setManufacturerData(const std::string &data) {
 
 /**
  * @brief Set the advertised URI.
- * @param [in] name The URI to advertise.
+ * @param [in] uri The URI to advertise.
  */
 void NimBLEAdvertising::setURI(const std::string &uri) {
     m_uri.assign(uri.begin(), uri.end());

src/NimBLECharacteristic.cpp

@@ -126,7 +126,7 @@ NimBLEDescriptor* NimBLECharacteristic::getDescriptorByUUID(const NimBLEUUID &uu
 
 /**
  * @brief Return the BLE Descriptor for the given handle.
- * @param [in] uuid The handle of the descriptor.
+ * @param [in] handle The handle of the descriptor.
  * @return A pointer to the descriptor object or nullptr if not found.
  */
 NimBLEDescriptor *NimBLECharacteristic::getDescriptorByHandle(uint16_t handle) {

src/NimBLEDevice.cpp

@@ -403,7 +403,7 @@ void NimBLEDevice::stopAdvertising() {
 
 
 /**
- * @brief Set the duplicate filter mode for filtering scanned devices.
+ * @brief Set the duplicate filter cache size for filtering scanned devices.
  * @param [in] cacheSize The number of advertisements filtered before the cache is reset.\n
  * Range is 10-1000, a larger value will reduce how often the same devices are reported.
  * @details Must only be called before calling NimBLEDevice::init.

src/esp-hci/src/esp_nimble_hci.c

@@ -523,10 +523,6 @@ esp_err_t esp_nimble_hci_and_controller_init(void)
     esp_bt_controller_mem_release(ESP_BT_MODE_CLASSIC_BT);
 
     esp_bt_controller_config_t bt_cfg = BT_CONTROLLER_INIT_CONFIG_DEFAULT();
-    /* Added to ensure BLE only mode */
-    bt_cfg.mode = ESP_BT_MODE_BLE;
-    /* Added to set max connections from nimconfig */
-    bt_cfg.ble_max_conn = CONFIG_BT_NIMBLE_MAX_CONNECTIONS;
 
     if ((ret = esp_bt_controller_init(&bt_cfg)) != ESP_OK) {
         return ret;