fix(handleCacheHeaders): round modifiedTime to seconds (#1262)

Author: amondnet

src/utils/cache.ts

@@ -25,6 +25,7 @@ export function handleCacheHeaders(
 
   if (opts.modifiedTime) {
     const modifiedTime = new Date(opts.modifiedTime);
+    modifiedTime.setMilliseconds(0);
     const ifModifiedSince = event.req.headers.get("if-modified-since");
     event.res.headers.set("last-modified", modifiedTime.toUTCString());
     if (ifModifiedSince && new Date(ifModifiedSince) >= modifiedTime) {

test/utils.test.ts

@@ -376,5 +376,20 @@ describeMatrix("utils", (t, { it, describe, expect }) => {
       });
       expect(res.status).toBe(304);
     });
+
+    it("handles modifiedTime with milliseconds correctly", async () => {
+      t.app.use((event) => {
+        handleCacheHeaders(event, {
+          modifiedTime: new Date("2021-01-01T00:00:00.500Z"),
+        });
+        return "ok";
+      });
+      const res = await t.fetch("/", {
+        headers: {
+          "if-modified-since": "Fri, 01 Jan 2021 00:00:00 GMT",
+        },
+      });
+      expect(res.status).toBe(304);
+    });
   });
 });