setCookie is not set for status error

[Pinegin]

Environment

"h3": "^2.0.1-rc.6"

Reproduction

defineHandler({
  middleware: [
    onResponse((response, event) => {
      setCookie(event, 'test', 'test')
    }),
  ],
  handler: (event) => {
    if (true) {
      return new HTTPResponse('test_2', { status: 300 })
    }

    return new HTTPResponse('test_1', { status: 299 })
  },
})

Describe the bug

if the response status is less than 300, cookies are set, if more than that, no cookies are set.

Additional context

No response

Logs

[coderabbitai]

🔗 Similar Issues

Related Issues

• The setCookie method executes twice to set the same set-cookie header. #1257
• setCookie applies cookie twice when set cookie with path #1238
• Returning Blob causes file download #1132
• proxyRequest does not work correctly with Bun #1246
• handleCors() returns falsy sentinel (""), conflicting with example usage. #1166

🔗 Related PRs

#1259 - fix: clear event.res after prepare [merged]

👤 Suggested Assignees

• starzou
• hahavenn
• huseeiin
• xxRockOnxx
• jakobrosenberg

---

Enable issue planning

_{To enable issue planning, add the following to your .coderabbit.yaml:}

issue_enrichment:
  planning:
    enabled: true

_{You can then request a plan by commenting @coderabbitai plan on any issue.}

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord or schedule a call!

[kricsleo]

This is intended for security.
The onResponse hook is mainly for successful responses. When modifying headers (e.g., setCookie) within this hook, they will be filtered out to prevent unintended header leakage.

[Pinegin]

It is not very logical that they are not deleted in case of errors and are installed after a successful response.
This is misleading.

onResponse(async (response, event) => {

  // only a successful response
  event.res.headers.set('x-test-1', 'test-1')

  // any responses
  response.headers.set('x-test-2', 'test-2')

  setCookie({ ...event, res: response }, COOKIE_NAME, COOKIE_VALUE)
})