fix: spinner bug

Author: vltansky

lib/cli.js

@@ -14,7 +14,6 @@ const packageName = "html5-boilerplate";
 const tempDir = os.tmpdir() + `/${packageName}-staging`;
 const elapsed = require("elapsed-time-logger");
 const compareVersions = require("compare-versions");
-let spinner;
 
 module.exports = async (argvs) => {
   const argv = yargs_parser(argvs, {
@@ -28,7 +27,7 @@ module.exports = async (argvs) => {
     console.log(chalk.red("Aborted"));
     return;
   }
-  spinner = ora(
+  let spinner = ora(
     `Downloading ${packageName} version '${version}' to ${targetDir}`
   ).start();
   await fs.ensureDir(tempDir);
@@ -40,21 +39,24 @@ module.exports = async (argvs) => {
     );
     await fs.copy(tempDir + "/dist", targetDir);
     const timerDownloaded = timer.get();
+    spinner.stop();
     await onLoad(targetDir, version, argv);
-    spinner.succeed(
-      `${nameWithVersion} copied to ${targetDir} in ${timerDownloaded}. Have fun!`
+    console.log(
+      chalk.green("✔") +
+        ` ${nameWithVersion} copied to ${targetDir} in ${timerDownloaded}. Have fun!`
     );
     return;
   } catch (err) {
+    spinner.stop();
     if (err.code === "ETARGET") {
       const msg = chalk.red(
-        `version '${err.wanted}' not found in npm registry\navailable versions:\n`
+        `✖ version '${err.wanted}' not found in npm registry\navailable versions:\n`
       );
       spinner.fail(msg + err.versions.reverse().join(" | "));
       throw err.code;
     }
     console.error(err);
-    spinner.fail("Unexpected error");
+    console.log(chalk.red("✖ Unexpected error"));
     throw new Error(err);
   } finally {
     await fs.remove(tempDir);