Skip to content

Commit ef4ebea

Browse files
chore: remove max-lines-per-function eslint rule (#157)
### TL;DR Removed the `max-lines-per-function` ESLint rule and its related disable comments throughout the codebase. ### What changed? - Removed the `max-lines-per-function` rule from `.eslintrc.js` - Removed all `eslint-disable max-lines-per-function` comments from various files across the project - Kept other ESLint configurations intact ### Why make this change? The `max-lines-per-function` rule was creating unnecessary constraints and noise in the codebase. Some functions legitimately needed to be longer due to their complexity or UI rendering requirements. Removing this rule allows for more flexible function lengths while maintaining other code quality standards.
1 parent 3581326 commit ef4ebea

File tree

17 files changed

+0
-17
lines changed

17 files changed

+0
-17
lines changed

.eslintrc.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ module.exports = {
2121
},
2222
],
2323
'max-params': ['error', 3], // Limit the number of parameters in a function to use object instead
24-
'max-lines-per-function': ['error', 70],
2524
'react/display-name': 'off',
2625
'react/no-inline-styles': 'off',
2726
'react/destructuring-assignment': 'off', // Vscode doesn't support automatically destructuring, it's a pain to add a new variable

app.config.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable max-lines-per-function */
21
import type { ConfigContext, ExpoConfig } from '@expo/config';
32

43
import { ClientEnv, Env } from './env';

src/api/habits/use-modify-entry.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable max-lines-per-function */
21
import { createMutation } from 'react-query-kit';
32

43
import { addTestDelay, queryClient } from '../common';

src/api/habits/use-press-habit-button.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable max-lines-per-function */
21
import { createMutation } from 'react-query-kit';
32

43
import { addTestDelay, queryClient } from '../common';

src/api/notifications/use-respond-to-notification.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable max-lines-per-function */
21
import { showMessage } from 'react-native-flash-message';
32
import { createMutation } from 'react-query-kit';
43

src/app/(tabs)/notifications.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable max-lines-per-function */
21
import { useQueries } from '@tanstack/react-query';
32
import React from 'react';
43

src/app/(tabs)/settings.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable max-lines-per-function */
21
/* eslint-disable react/react-in-jsx-scope */
32
import { Env } from '@env';
43
import { Linking } from 'react-native';

src/app/auth/index.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ const emailSchema = z.object({
1919

2020
type EmailFormType = z.infer<typeof emailSchema>;
2121

22-
// eslint-disable-next-line max-lines-per-function
2322
export default function Auth() {
2423
const router = useRouter();
2524
const { handleSubmit, control } = useForm<EmailFormType>({

src/app/habits/edit-habit.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable max-lines-per-function */
21
import { BottomSheetScrollView } from '@gorhom/bottom-sheet';
32
import { zodResolver } from '@hookform/resolvers/zod';
43
import { router } from 'expo-router';

src/app/habits/view-habit.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
/* eslint-disable max-lines-per-function */
21
import { BottomSheetScrollView } from '@gorhom/bottom-sheet';
32
import { Link, useLocalSearchParams } from 'expo-router';
43
import {

0 commit comments

Comments
 (0)