Allow attendees to won several times

... if there are more prizes than attendees

Author: fbiville

lib/raffle.js

@@ -1,9 +1,7 @@
-
 class RaffleCandidate {
     constructor(id, name, email, avatar) {
         this._id = id;
         this._name = name;
-        this._email = email;
         this._avatar = avatar;
     }
 }
@@ -30,9 +28,10 @@ class RaffleStatus {
 
 class Raffle {
     constructor(candidates, prizes) {
-        this._winners = new Set();
+        this._results = new Set();
         this._candidates = candidates
         this._prizes = prizes;
+        this._threshold = Math.ceil(this._prizes.length / this._candidates.length);
     }
 
     run() {
@@ -41,37 +40,38 @@ class Raffle {
         }
         const candidates = this._filterCandidates();
         const winner = this._randomPick(candidates);
-        this._winners.add(winner);
-        return new RaffleResult(winner, this._prizes[this._winners.size - 1]);
+        const prize = this._currentPrize();
+        const result = new RaffleResult(winner, prize);
+        this._results.add(result);
+        return result;
     }
 
     reset() {
-        this._winners = new Set();
+        this._results = new Set();
     }
 
     status() {
-        const results = Array.from(this._winners).map((winner, i) => new RaffleResult(winner, this._prizes[i]));
-        return new RaffleStatus(results, this._isCompleted());
+        return new RaffleStatus(Array.from(this._results), this._isCompleted());
     }
 
     cancel(userId) {
-        const user = this._findWinnerById(userId);
-        if (!user) {
+        const result = this._findResultByUserId(userId);
+        if (!result) {
             return;
         }
-        this._winners.delete(user);
+        this._results.delete(result);
     }
 
-    _findWinnerById(userId) {
-        return Array.from(this._winners).find((winner) => winner._id === userId);
+    _findResultByUserId(userId) {
+        return Array.from(this._results).find((result) => result._winner._id === userId);
     }
 
     _isCompleted() {
-        return this._winners.size === this._prizes.length;
+        return this._results.size === this._prizes.length;
     }
 
     _filterCandidates() {
-        return this._candidates.filter((user) => !this._winners.has(user));
+        return this._candidates.filter((user) => this._hasUserWonLessThan(user));
     }
 
     _randomPick(candidates) {
@@ -80,6 +80,20 @@ class Raffle {
         }
         return candidates[Math.floor(Math.random() * Math.floor(candidates.length))];
     }
+
+    _hasUserWonLessThan(user) {
+        let count = 0;
+        this._results.forEach((result) => {
+            if (result._winner === user && result._prize._description !== this._currentPrize()._description) {
+                count++;
+            }
+        })
+        return count < this._threshold;
+    }
+
+    _currentPrize() {
+        return this._prizes[this._results.size];
+    }
 }
 
 module.exports = {RaffleCandidate, RaffleWinner: RaffleResult, RafflePrize, Raffle};