Add nice-to-have

fbiville · fbiville · commit 2fd41674e2ce · 2021-05-29T01:51:19.000+02:00
diff --git a/lib/raffle-candidate-service.js b/lib/raffle-candidate-service.js
@@ -12,12 +12,14 @@ module.exports = class RaffleCandidateService {
         return this._slackUserRepository.findAllByIds(eligibleParticipantIds)
     }
 
+    // TODO: make channel name configurable
     async _findOrgIds() {
         return this._slackChannelRepository.findOne('paris2021-org', true)
             .then(channel => channel.id)
             .then(channelId => this._slackUserRepository.findAllMemberIds(channelId))
     }
 
+    // TODO: make channel name configurable
     async _findAllRaffleCandidateIds() {
         return this._slackChannelRepository.findOne('paris2021-raffle', false)
             .then(channel => channel.id)

Original file line number	Diff line number	Diff line change
`@@ -12,12 +12,14 @@ module.exports = class RaffleCandidateService {`
`12`	`12`	`return this._slackUserRepository.findAllByIds(eligibleParticipantIds)`
`13`	`13`	`}`
`14`	`14`
	`15`	`+ // TODO: make channel name configurable`
`15`	`16`	`async _findOrgIds() {`
`16`	`17`	`return this._slackChannelRepository.findOne('paris2021-org', true)`
`17`	`18`	`.then(channel => channel.id)`
`18`	`19`	`.then(channelId => this._slackUserRepository.findAllMemberIds(channelId))`
`19`	`20`	`}`
`20`	`21`
	`22`	`+ // TODO: make channel name configurable`
`21`	`23`	`async _findAllRaffleCandidateIds() {`
`22`	`24`	`return this._slackChannelRepository.findOne('paris2021-raffle', false)`
`23`	`25`	`.then(channel => channel.id)`