Fix broken settings persistence when options opened from privileged page and reload required.

hackademix · hackademix · commit e95013c078b3 · 2024-10-22T11:06:14.000+02:00
diff --git a/src/bg/Settings.js b/src/bg/Settings.js
@@ -180,8 +180,10 @@ var Settings = {
     if (typeof unrestrictedTab === "boolean") {
       ns.unrestrictedTabs[unrestrictedTab ? "add" : "delete"](tabId);
     }
-    if (reloadAffected) {
-      browser.tabs.reload(tabId);
+    if (reloadAffected && tabId !== -1) {
+      try {
+        browser.tabs.reload(tabId);
+      } catch (e) {}
     }
 
     if (xssUserChoices) await XSS.saveUserChoices(xssUserChoices);

Original file line number	Diff line number	Diff line change
`@@ -180,8 +180,10 @@ var Settings = {`
`180`	`180`	`if (typeof unrestrictedTab === "boolean") {`
`181`	`181`	`ns.unrestrictedTabs[unrestrictedTab ? "add" : "delete"](tabId);`
`182`	`182`	`}`
`183`		`- if (reloadAffected) {`
`184`		`- browser.tabs.reload(tabId);`
	`183`	`+ if (reloadAffected && tabId !== -1) {`
	`184`	`+ try {`
	`185`	`+ browser.tabs.reload(tabId);`
	`186`	`+ } catch (e) {}`
`185`	`187`	`}`
`186`	`188`
`187`	`189`	`if (xssUserChoices) await XSS.saveUserChoices(xssUserChoices);`