Skip to content

Commit 218c72a

Browse files
committed
Use requests's pagination support
1 parent 34994d0 commit 218c72a

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

src/labels/github.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,18 +71,15 @@ def list_labels(self, repo: Repository) -> typing.List[Label]:
7171
)
7272
json = response.json()
7373

74-
link_header = response.headers.get('Link', '')
75-
next_page = [l for l in link_header.split(',') if 'rel="next"' in l]
74+
next_page = response.links.get('next', None)
7675
while next_page:
77-
l, _ = next_page[0].split(';')
78-
logger.debug(f"Requesting {l.split('?')[1]}")
76+
logger.debug(f"Requesting {next_page}")
7977
response = self.session.get(
80-
l[1:-1],
78+
next_page['url'],
8179
headers={"Accept": "application/vnd.github.symmetra-preview+json"},
8280
)
8381
json.extend(response.json())
84-
link_header = response.headers.get('Link', '')
85-
next_page = [l for l in link_header.split(',') if 'rel="next"' in l]
82+
next_page = response.links.get('next', None)
8683

8784
if response.status_code != 200:
8885
raise GitHubException(

0 commit comments

Comments
 (0)