hackerby888
diff --git a/‎.github/workflows/contract-verify.yml‎
Lines changed: 37 additions & 0 deletions b/‎.github/workflows/contract-verify.yml‎
Lines changed: 37 additions & 0 deletions
diff --git a/‎.gitignore‎
Lines changed: 1 addition & 0 deletions b/‎.gitignore‎
Lines changed: 1 addition & 0 deletions
diff --git a/‎.idea/editor.xml‎
Lines changed: 1 addition & 0 deletions b/‎.idea/editor.xml‎
Lines changed: 1 addition & 0 deletions
diff --git a/‎CMakeLists.txt‎
Lines changed: 4 additions & 4 deletions b/‎CMakeLists.txt‎
Lines changed: 4 additions & 4 deletions
diff --git a/‎README.md‎
Lines changed: 18 additions & 4 deletions b/‎README.md‎
Lines changed: 18 additions & 4 deletions
diff --git a/‎README_CLANG.md‎
Lines changed: 14 additions & 7 deletions b/‎README_CLANG.md‎
Lines changed: 14 additions & 7 deletions
diff --git a/‎doc/contracts.md‎
Lines changed: 3 additions & 0 deletions b/‎doc/contracts.md‎
Lines changed: 3 additions & 0 deletions
diff --git a/‎doc/contributing.md‎
Lines changed: 18 additions & 0 deletions b/‎doc/contributing.md‎
Lines changed: 18 additions & 0 deletions
diff --git a/‎lib/platform_common/CMakeLists.txt‎
Lines changed: 2 additions & 6 deletions b/‎lib/platform_common/CMakeLists.txt‎
Lines changed: 2 additions & 6 deletions
diff --git a/‎lib/platform_common/long_jump.h‎
Lines changed: 2 additions & 2 deletions b/‎lib/platform_common/long_jump.h‎
Lines changed: 2 additions & 2 deletions
@@ -0,0 +1,37 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+
+name: ContractVerify
+
+on:
+  push:
+    branches: [ "main", "develop" ]
+    paths:
+      - 'src/contracts/*.h'
+      - '.github/workflows/contract-verify.yml'
+  pull_request:
+    branches: [ "main", "develop" ]
+    paths:
+      - 'src/contracts/*.h'
+      - '.github/workflows/contract-verify.yml'
+
+jobs:
+  contract_verify_job:
+    runs-on: ubuntu-latest
+    name: Verify smart contract files
+    steps:
+      # Checkout repo to use files of the repo as input for container action
+      - name: Checkout
+        uses: actions/checkout@v4
+      - name: Find all contract files to verify
+        id: filepaths
+        run: |
+          files=$(find src/contracts/ -maxdepth 1 -type f -name "*.h" ! -name "*TestExample*" ! -name "*math_lib*" ! -name "*qpi*" -printf "%p\n" | paste -sd, -)
+          echo "contract-filepaths=$files" >> "$GITHUB_OUTPUT"
+      - name: Contract verify action step
+        id: verify
+        uses: Franziska-Mueller/qubic-contract-verify@v0.3.3-beta
+        with:
+          filepaths: '${{ steps.filepaths.outputs.contract-filepaths }}'
@@ -13,3 +13,4 @@ x64/
 .DS_Store
 .clang-format
 tmp
+build/
@@ -12,7 +12,7 @@ include(CompilerSetup)
 # Build options
 option(BUILD_TESTS "Build the test suite" ON)
 option(BUILD_BENCHMARK "Build the EFI benchmark application" OFF)
-option(BUILD_EFI "Build the EFI application" ON)
+option(BUILD_BINARY "Build the EFI application" ON)
 option(USE_SANITIZER "Build test with sanitizer support (clang only)" ON)
 
 if(IS_WINDOWS)
@@ -25,7 +25,7 @@ endif()
 # Always include platform_common as it's needed for both application and tests
 add_subdirectory(lib/platform_common)
 
-if(BUILD_EFI OR BUILD_BENCHMARK)
+if(BUILD_BINARY OR BUILD_BENCHMARK)
     add_subdirectory(lib/platform_efi)
 endif()
 
@@ -37,15 +37,15 @@ if(BUILD_TESTS)
 
     # If we're not building the application, we still need src for tests
     # but don't make it a default target
-    if(NOT BUILD_EFI)
+    if(NOT BUILD_BINARY)
         add_subdirectory(src EXCLUDE_FROM_ALL)
     endif()
 
     add_subdirectory(test)
 endif()
 
 # Build the application if requested
-if(BUILD_EFI)
+if(BUILD_BINARY)
     message(STATUS "--- EFI Core application ---")
     add_subdirectory(src)
 endif()
 
@@ -4,11 +4,23 @@ The lite version of Qubic Core that can run directly on the OS without a UEFI en
 
 ## Build
 
+### Pre-build Binary
+
+Pre-build binary can be found here
 > Lite Executable <br>
 > [![Build](https://github.com/hackerby888/qubic-core-lite/actions/workflows/efi-build-develop.yml/badge.svg?branch=main)](https://github.com/hackerby888/qubic-core-lite/actions/workflows/efi-build-develop.yml)
 > <br>
 > The executable is located in `QubicLiteBuildOutput.zip/x64/Release/Qubic.exe`
 
+### Windows
+
+- Open .sln file in project root folder in Visual Studio
+- Change build config to Release -> Right click at Qubic project -> Build
+
+### Linux
+
+Detailed instruction can be found here: [Linux Build Tutorial](./README_CLANG.md)
+
 ## Prerequisites
 
 To run a qubic node, you need the following spec:
@@ -56,14 +68,16 @@ static const unsigned char knownPublicPeers[][4] = {
 - An epoch will have `TESTNET_EPOCH_DURATION` (**3000**) ticks by default, you can change it in `public_settings.h`
 - You can deploy your own RPC server of local devnet [how to](https://qubic-sc-docs.pages.dev/rpc/setup-rpc)
 
+## FAQs
+
+- **My node stop ticking after restart, why?**
+Delete the **system** file at your current working folder, it may make your node start with wrong state.
+
 ## Supporting Platform
 
 - [x] Windows
-- [ ] Linux (Soon...)
+- [x] Linux
 
 ## Donate The Project
 
 QUBIC Wallet: QPROLAPACSPVBDQADRXXKRGZMXADUAEXXJIQNWPGWFUFUAITRXMHVODDLGBK
-
-
-
 
@@ -1,6 +1,4 @@
-# qubic clang port
-The Qubic Core is currently ported to be compiled with clang. As this requires a lot of changes the port is develop along the main development work and continuously integrated. However this also implies that the compilation of the core code with clang is not resulting in a working node at the moment. Hence it shall now be used in production!
-
+# Qubic Lite Core Linux Build
 
 ## Prerequisites
 To be able to compile the core code with clang the following prerequisites have to be meet:
@@ -11,6 +9,14 @@ To be able to compile the core code with clang the following prerequisites have
 
 Potentially it also works with lower versions but isn't tested yet.
 
+## Compiler Installation Commands
+
+```
+sudo apt update && upgrade
+sudo apt install -y build-essential clang cmake nasm
+sudo apt install -y libc++-dev libc++abi-dev
+```
+
 ## Compilation
 Currently compilation with cmake and clang is only supported on Linux systems. Window and OSX might work but is not properly tested.
 For a example compilation execute the following commands:
@@ -38,7 +44,7 @@ For a example compilation execute the following commands:
 
     ```bash
     # In your build directory
-    cmake .. -D CMAKE_C_COMPILER=clang -D CMAKE_CXX_COMPILER=clang++ -D BUILD_TESTS:BOOL=ON -D BUILD_EFI:BOOL=OFF -D CMAKE_BUILD_TYPE=Debug -D ENABLE_AVX512=ON
+    cmake .. -D CMAKE_C_COMPILER=clang -D CMAKE_CXX_COMPILER=clang++ -D BUILD_TESTS:BOOL=OFF -D BUILD_BINARY:BOOL=ON -D CMAKE_BUILD_TYPE=Release -D ENABLE_AVX512=OFF
     ```
 
     There are a few option to set during configuration:
@@ -47,7 +53,7 @@ For a example compilation execute the following commands:
     * **Values:** `ON`, `OFF`
     * **Meaning:** `ON` builds the test suite, `OFF` skips building tests.
 
-* **`-D BUILD_EFI=<ON|OFF>`**
+* **`-D BUILD_BINARY=<ON|OFF>`**
     * **Values:** `ON`, `OFF`
     * **Meaning:** `ON` builds the EFI file, `OFF` skips building EFI file. Currently this build is not working.
 
@@ -79,11 +85,12 @@ For a example compilation execute the following commands:
     # Or if using Ninja (often the default if installed), it usually uses all cores by default
     ```
 
+The output binary will be located at `build/src`
 
 ## State
-At the moment the basic build scripts are setup and tests will be ported piece by piece.
 
-Current state of the working tests:
+The core binary are finished but for building test are still pending
+
 | Test Module        | Source File             | Status      |
 | :----------------- | :---------------------- | :---------- |
 | Assets             | `assets.cpp`            | Pending     |
 
@@ -632,3 +632,6 @@ The file `proposal.cpp` has a lot of examples showing how to use both functions.
 For example, `getProposalIndices()` shows how to call a contract function requiring input and providing output with `runContractFunction()`.
 An example use case of `makeContractTransaction()` can be found in `gqmpropSetProposal()`.
 The function `castVote()` is a more complex example combining both, calling a contract function and invoking a contract procedure.
+
+
+
@@ -191,6 +191,8 @@ The code formatting rules are enforced using `clang-format`, ideally setup as a
 They are based on the "Microsoft" style with some custom modifications.
 Currently, the style guidelines are designed to improve consistency while minimizing the number of changes needed in the existing codebase.
 
+#### Naming
+
 The following naming rules are not strictly enforced, but should be followed at least in new code:
 
 - **Preprocessor symbols** must be defined `ALL_CAPS`.
@@ -221,6 +223,21 @@ The following naming rules are not strictly enforced, but should be followed at
 
 - **Functions** are named following the same pattern as variables. They usually start with a verb. Examples: `getComputerDigest()`, `processExchangePublicPeers()`, `initContractExec()`.
 
+#### Curly Braces Style
+
+Every opening curly brace should be on a new line. This applies to conditional blocks, loops, functions, classes, structs, etc. For example:
+
+```
+if (cond)
+{
+   // do something
+}
+else
+{
+   // do something else
+}
+```
+
 
 
 ## Version naming scheme
@@ -373,3 +390,4 @@ Even when bound by serializing instructions, the system environment at the time
 [AMD64 Architecture Programmer's Manual, Volumes 1-5, 13.2.4 Time-Stamp Counter](https://www.amd.com/content/dam/amd/en/documents/processor-tech-docs/programmer-references/40332.pdf)
 
 Another rich source: [Intel® 64 and IA-32 Architectures Software Developer's Manual Combined Volumes: 1, 2A, 2B, 2C, 2D, 3A, 3B, 3C, 3D, and 4](https://cdrdv2.intel.com/v1/dl/getContent/671200)
+
@@ -47,8 +47,6 @@ elseif(IS_LINUX_CLANG AND ASM_LANG STREQUAL ASM_NASM)
         COMMENT "Preprocessing/Assembling (NASM) ${NASM_SRC_LJ}"
         VERBATIM
     )
-    add_library(LongJumpNasmObject OBJECT ${NASM_OBJ_LJ})
-    set_target_properties(LongJumpNasmObject PROPERTIES LINKER_LANGUAGE C)
     list(APPEND ASM_OBJECT_LIBS LongJumpNasmObject)
 
     # --- NASM File 2: SetJump ---
@@ -64,14 +62,12 @@ elseif(IS_LINUX_CLANG AND ASM_LANG STREQUAL ASM_NASM)
         COMMENT "Preprocessing/Assembling (NASM) ${NASM_SRC_SJ}"
         VERBATIM
     )
-    add_library(SetJumpNasmObject OBJECT ${NASM_OBJ_SJ})
-    set_target_properties(SetJumpNasmObject PROPERTIES LINKER_LANGUAGE C)
     list(APPEND ASM_OBJECT_LIBS SetJumpNasmObject)
 
 endif()
 
 # --- Target Definition ---
-add_library(platform_common STATIC ${C_SOURCES})
+add_library(platform_common STATIC ${C_SOURCES} ${CMAKE_CURRENT_BINARY_DIR}/LongJump.nasm.o ${CMAKE_CURRENT_BINARY_DIR}/SetJump.nasm.o)
 
 # Apply common compiler flags from the centralized detection module
 apply_common_compiler_flags(platform_common)
@@ -81,7 +77,7 @@ if(ASM_OBJECT_LIBS)
     if(IS_WINDOWS)
         target_link_libraries(platform_common PRIVATE platform_common_asm)
     else()
-        target_link_libraries(platform_common PRIVATE ${ASM_OBJECT_LIBS})
+        # For Linux, link the object files directly
     endif()
 endif()
 
 
@@ -48,7 +48,7 @@ extern "C"
       @retval 0 Indicates a return from SetJump().
 
     **/
-    unsigned long long _cdecl SetJump(LongJumpBuffer* JumpBuffer);
+    unsigned long long SetJump(LongJumpBuffer* JumpBuffer);
 
 
     /**
@@ -67,6 +67,6 @@ extern "C"
                           restored and must be non-zero.
 
     **/
-    void _cdecl LongJump(LongJumpBuffer* JumpBuffer, unsigned long long Value);
+    void LongJump(LongJumpBuffer* JumpBuffer, unsigned long long Value);
 
 }