Skip to content

Commit f103859

Browse files
dahliaclaude
andcommitted
Fix typos and bugs from code review feedback
- Fix Korean spelling error in email template: "메세지" → "메시지" - Fix Traditional Chinese typo: "通行通行金鑰" → "通行金鑰" - Optimize negotiateLocale performance by precomputing maximize() results - Fix accessibility issue with label for attribute mismatch Co-Authored-By: Claude <[email protected]>
1 parent 43e43c8 commit f103859

File tree

4 files changed

+19
-18
lines changed

4 files changed

+19
-18
lines changed

graphql/locales/ko.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,6 @@
66
"invite": {
77
"emailSubject": "{{inviterName}} 님이 Hackers' Pub에 초대합니다!",
88
"emailContent": "{{inviter}} 님이 Hackers' Pub에 초대합니다!\n\nHackers' Pub은 소프트웨어 프로그래머들이 지식과 경험을 서로 나누는 곳입니다. 또한 ActivityPub을 지원하는 소셜 네트워크이기도 하며, 연합우주(fediverse)에서 즐겨찾는 소프트웨어 프로그래머들을 팔로하고 최신 콘텐츠를 받아 볼 수 있습니다.\n\n초대장을 받으려면 아래 링크를 클릭하세요:\n\n{{verifyUrl}}\n\n이 링크는 {{expiration}} 후에 만료됩니다.\n",
9-
"emailContentWithMessage": "{{inviter}} 님이 Hackers' Pub에 초대합니다! 다음은 {{inviterName}} 님의 메세지입니다:\n\n{{message}}\n\n초대장을 받으려면 아래 링크를 클릭하세요:\n\n{{verifyUrl}}\n\n이 링크는 {{expiration}} 후에 만료됩니다.\n"
9+
"emailContentWithMessage": "{{inviter}} 님이 Hackers' Pub에 초대합니다! 다음은 {{inviterName}} 님의 메시지입니다:\n\n{{message}}\n\n초대장을 받으려면 아래 링크를 클릭하세요:\n\n{{verifyUrl}}\n\n이 링크는 {{expiration}} 후에 만료됩니다.\n"
1010
}
1111
}

models/i18n.ts

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -186,37 +186,38 @@ export function negotiateLocale(
186186
: wantedLocales,
187187
];
188188

189-
const availables = availableLocales.map((l) =>
189+
const availableLocalesNormalized = availableLocales.map((l) =>
190190
typeof l === "string" ? new Intl.Locale(l) : l
191191
);
192+
const availablesWithMaximized = availableLocalesNormalized.map((raw) => ({
193+
raw,
194+
max: raw.maximize(),
195+
}));
192196

193197
for (const wanted of wantedArray) {
194198
const wantedMaximized = wanted.maximize();
195199

196200
// First try exact match
197-
for (const available of availables) {
198-
const availableMaximized = available.maximize();
199-
if (wantedMaximized.baseName === availableMaximized.baseName) {
200-
return available;
201+
for (const a of availablesWithMaximized) {
202+
if (wantedMaximized.baseName === a.max.baseName) {
203+
return a.raw;
201204
}
202205
}
203206

204207
// Then try language + script match (e.g., zh-Hant)
205-
for (const available of availables) {
206-
const availableMaximized = available.maximize();
208+
for (const a of availablesWithMaximized) {
207209
if (
208-
wantedMaximized.language === availableMaximized.language &&
209-
wantedMaximized.script === availableMaximized.script
210+
wantedMaximized.language === a.max.language &&
211+
wantedMaximized.script === a.max.script
210212
) {
211-
return available;
213+
return a.raw;
212214
}
213215
}
214216

215217
// Finally try language-only match
216-
for (const available of availables) {
217-
const availableMaximized = available.maximize();
218-
if (wantedMaximized.language === availableMaximized.language) {
219-
return available;
218+
for (const a of availablesWithMaximized) {
219+
if (wantedMaximized.language === a.max.language) {
220+
return a.raw;
220221
}
221222
}
222223
}

web-next/src/locales/zh-TW/messages.po

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -625,7 +625,7 @@ msgstr "為你的帳戶註冊通行金鑰。你可以使用通行金鑰登入,
625625

626626
#: src/routes/(root)/[handle]/settings/passkeys.tsx:427
627627
msgid "Registered passkeys"
628-
msgstr "已註冊的通行通行金鑰"
628+
msgstr "已註冊的通行金鑰"
629629

630630
#: src/routes/(root)/[handle]/settings/passkeys.tsx:420
631631
msgid "Registering…"
@@ -742,7 +742,7 @@ msgstr "電子郵件地址不僅用於接收邀請,還用於登入帳戶。"
742742

743743
#: src/routes/(root)/[handle]/settings/passkeys.tsx:429
744744
msgid "The following passkeys are registered to your account. You can use them to sign in to your account."
745-
msgstr "以下通行通行金鑰已註冊到你的帳戶。你可以使用它們登入你的帳戶。"
745+
msgstr "以下通行金鑰已註冊到你的帳戶。你可以使用它們登入你的帳戶。"
746746

747747
#: src/routes/(root)/[handle]/settings/invite.tsx:167
748748
msgid "The invitation has been sent successfully."

web-next/src/routes/(root)/[handle]/settings/preferences.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,7 @@ export default function PreferencesPage() {
202202
defaultChecked={account().preferAiSummary}
203203
/>
204204
<div class="grid gap-1.5 leading-none">
205-
<Label for="prefer-ai-summary-input">
205+
<Label for="prefer-ai-summary">
206206
{t`Prefer AI-generated summary`}
207207
</Label>
208208
<p class="text-sm text-muted-foreground">

0 commit comments

Comments
 (0)