Skip to content

Conversation

@aymeviviana
Copy link
Member

@aymeviviana aymeviviana commented Aug 27, 2025

Please note: You must be a member of the HFLA website team in order to create pull requests. Please see our page on how to join us as a member at HFLA: https://www.hackforla.org/getting-started. Delete this message if you joined this team via onboarding.

Fixes #8109

What changes did you make?

  • Removed Roja Pinnamraju profile from the Current Project Team section on the Civic Tech Jobs page

Why did you make the changes (we will use this info to test)?

  • To keep the list of active team members current

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b aymeviviana-update-project-profile-8109 gh-pages
git pull https://github.com/aymeviviana/website.git update-project-profile-8109

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 27, 2025
@xnealcarson xnealcarson self-requested a review August 28, 2025 01:10
@kdaca19xx kdaca19xx requested review from kdaca19xx and removed request for xnealcarson August 28, 2025 01:10
@kdaca19xx
Copy link
Member

Availability: after 1pm (pacific)
ETA: 8/29

@xnealcarson xnealcarson self-requested a review August 28, 2025 01:12
@kdaca19xx kdaca19xx requested a review from xnealcarson August 28, 2025 01:12
@xnealcarson
Copy link
Member

Availability: After 4pm PST
ETA: 8/29 by end of day

@kdaca19xx
Copy link
Member

Availability: after 1pm (pacific) ETA: 8/29

I need to reach out to someone about a Git issue keeping me from doing this review and meeting my original deadline.

My new ETA is 8/31.

xnealcarson

This comment was marked as duplicate.

@lastCoyotes
Copy link
Member

Review ETA: by 10 PM 9/4
Availability: 12-7 PM Mon-Thurs

Copy link
Member

@lastCoyotes lastCoyotes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made are good! I don't see anything to catch that would be an issue.
Visual changes confirmed and consistent on my end too.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Sep 5, 2025
Copy link
Member

@kdaca19xx kdaca19xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, aymeviviana!

Things Done Well

  • The pull request was done with the correct branch.

  • There's a linked issue, and I understood it.

  • Your deletions shown in the Files Changed tab look good (including the lines of code that were deleted then added back). I can see the changes in Docker too.

Suggestions

  • You didn't tick a box in the CodeQL Alerts section. Is this because the check failed for the Member Activity Trigger / Gather-Activity-Event-Information (pull_request_review) file? Either way, it's my understanding that a box needs to be ticked.
  • Because the the Member Activity Trigger / Gather-Activity-Event-Information (pull_request_review) check didn't pass, the merge icon below is gray. This means there's a conflict preventing the merge. You should definitely reach out to a team lead about this.

I don't know if I can approve this yet (I've been there!). I'm going to hold off until I learn more the lead who reviews this.

All the same, thanks again for all your hard work, aymeviviana!

@github-project-automation github-project-automation bot moved this from PRs ✅ waiting for merge team to PRs being reviewed in P: HfLA Website: Project Board Sep 5, 2025
@kdaca19xx
Copy link
Member

Suggestions

  • You didn't tick a box in the CodeQL Alerts section. Is this because the check failed for the Member Activity Trigger / Gather-Activity-Event-Information (pull_request_review) file? Either way, it's my understanding that a box needs to be ticked.
  • Because the the Member Activity Trigger / Gather-Activity-Event-Information (pull_request_review) check didn't pass, the merge icon below is gray. This means there's a conflict preventing the merge. You should definitely reach out to a team lead about this.

I don't know if I can approve this yet (I've been there!). I'm going to hold off until I learn more the lead who reviews this.

All the same, thanks again for all your hard work, aymeviviana!

I got the notification below. @t-will-gillis or @mugdhchauhan, and I know it's related to what I was recently helped today, but it's the file that hadn't pass the check for this PR. Please advise.

image

@t-will-gillis
Copy link
Member

t-will-gillis commented Sep 5, 2025

The "Member Activity Trigger" failing check should be ignored. It is unrelated to the PR.

@t-will-gillis I forgot to ask if, in this case, is it okay to not put a ✔️ in the CodeQL Alerts section? I don't want to lag on approving this.

@xnealcarson
Copy link
Member

I already posted my review with an approval but for some reason, a review is still being requested from me. Any reason why that is @t-will-gillis ?

@t-will-gillis
Copy link
Member

t-will-gillis commented Sep 7, 2025

@aymeviviana To let you know, you don't need to self-assign on a PR (though it doesn't affect the PR either.)

@kdaca19xx

@t-will-gillis I forgot to ask if, in this case, is it okay to not put a ✔️ in the CodeQL Alerts section? I don't want to lag on approving this.

Although it is minor, it is part of the process for preparing a PR. I would request this change.

@xnealcarson

I already posted my review with an approval but for some reason, a review is still being requested from me. Any reason why that is @t-will-gillis ?

The only thing I see is that your Approval might have reset when @aymeviviana self-assigned.

@github-actions github-actions bot added Complexity: Small Take this type of issues after the successful merge of your second good first issue Ready for Prioritization Issue Making: Level 2 Make issue(s) from an ER or Epic labels Sep 8, 2025
@aymeviviana
Copy link
Member Author

@kdaca19xx - Thank you for your note. I just reviewed the comments for CodeQL alerts and didn't find any so I checked the appropriate box as requested. Screenshot included below ⬇️. I think i just missed this detail at the end of the process. I'll pay closer attention to it during my next PR.
Screenshot 2025-09-08 at 9 46 25 AM

@t-will-gillis - Noted. I will avoid self-assigning the PR in the future. Thank your for all of your help this last week! I just made the change that @kdaca19xx requested. Would you kindly advise if there are any other steps I should to take to push this PR to the merge phase? Thank you so much!

@daras-cu daras-cu removed Complexity: Small Take this type of issues after the successful merge of your second good first issue Ready for Prioritization Issue Making: Level 2 Make issue(s) from an ER or Epic labels Sep 10, 2025
@LRenDO
Copy link
Member

LRenDO commented Sep 10, 2025

Hi @aymeviviana! You can re-request a review from @kdaca19xx by clicking the arrow circle next to their handle in the reviewers section to notify them the changes are ready for review. Once they approve, we will merge the changes!

Copy link
Member

@xnealcarson xnealcarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @aymeviviana! Many thanks for taking on this issue.

Things Done Well

  • The issue has the correct 'commit into': "hackforla:gh-pages".
  • the 'commit from' and 'collaborator' names match.
  • The linked issue is present.
  • The changes made are applicable and clean.
  • Changes were viewable in browser.

Suggestions

There doesn't appear to be anything that needs to be changed, so you should be all set after all reviews are approved

Thanks again, @aymeviviana. Keep up the great work!

Copy link
Member

@kdaca19xx kdaca19xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your hard work, aymeviviana!

Things Done Well

  • The pull request was done with the correct branch.
  • There's a linked issue, and I understood it.
  • Your deletions shown in the Files Changed tab look good (including the lines of code that were deleted then added back). I can see the changes in Docker too.
  • You checked a box in the the CodeQL Alerts section.

Suggestions

n/a

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Sep 10, 2025
@t-will-gillis t-will-gillis merged commit 6094dc0 into hackforla:gh-pages Sep 11, 2025
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Update Project Profile: Civic Tech Jobs - Remove Roja Pinnamraju

7 participants