-
-
Notifications
You must be signed in to change notification settings - Fork 843
Remove Roja Pinnamraju from Civic Tech Jobs Page #8301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Roja Pinnamraju from Civic Tech Jobs Page #8301
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: after 1pm (pacific) |
|
Availability: After 4pm PST |
I need to reach out to someone about a Git issue keeping me from doing this review and meeting my original deadline. My new ETA is 8/31. |
|
Review ETA: by 10 PM 9/4 |
lastCoyotes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes made are good! I don't see anything to catch that would be an issue.
Visual changes confirmed and consistent on my end too.
kdaca19xx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, aymeviviana!
Things Done Well
-
The pull request was done with the correct branch.
-
There's a linked issue, and I understood it.
-
Your deletions shown in the Files Changed tab look good (including the lines of code that were deleted then added back). I can see the changes in Docker too.
Suggestions
- You didn't tick a box in the CodeQL Alerts section. Is this because the check failed for the Member Activity Trigger / Gather-Activity-Event-Information (pull_request_review) file? Either way, it's my understanding that a box needs to be ticked.
- Because the the Member Activity Trigger / Gather-Activity-Event-Information (pull_request_review) check didn't pass, the merge icon below is gray. This means there's a conflict preventing the merge. You should definitely reach out to a team lead about this.
I don't know if I can approve this yet (I've been there!). I'm going to hold off until I learn more the lead who reviews this.
All the same, thanks again for all your hard work, aymeviviana!
I got the notification below. @t-will-gillis or @mugdhchauhan, and I know it's related to what I was recently helped today, but it's the file that hadn't pass the check for this PR. Please advise.
|
@t-will-gillis I forgot to ask if, in this case, is it okay to not put a ✔️ in the CodeQL Alerts section? I don't want to lag on approving this. |
|
I already posted my review with an approval but for some reason, a review is still being requested from me. Any reason why that is @t-will-gillis ? |
|
@aymeviviana To let you know, you don't need to self-assign on a PR (though it doesn't affect the PR either.)
Although it is minor, it is part of the process for preparing a PR. I would request this change.
The only thing I see is that your Approval might have reset when @aymeviviana self-assigned. |
|
@kdaca19xx - Thank you for your note. I just reviewed the comments for CodeQL alerts and didn't find any so I checked the appropriate box as requested. Screenshot included below ⬇️. I think i just missed this detail at the end of the process. I'll pay closer attention to it during my next PR. @t-will-gillis - Noted. I will avoid self-assigning the PR in the future. Thank your for all of your help this last week! I just made the change that @kdaca19xx requested. Would you kindly advise if there are any other steps I should to take to push this PR to the merge phase? Thank you so much! |
|
Hi @aymeviviana! You can re-request a review from @kdaca19xx by clicking the arrow circle next to their handle in the reviewers section to notify them the changes are ready for review. Once they approve, we will merge the changes! |
xnealcarson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @aymeviviana! Many thanks for taking on this issue.
Things Done Well
- The issue has the correct 'commit into': "hackforla:gh-pages".
- the 'commit from' and 'collaborator' names match.
- The linked issue is present.
- The changes made are applicable and clean.
- Changes were viewable in browser.
Suggestions
There doesn't appear to be anything that needs to be changed, so you should be all set after all reviews are approved
Thanks again, @aymeviviana. Keep up the great work!
kdaca19xx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your hard work, aymeviviana!
Things Done Well
- The pull request was done with the correct branch.
- There's a linked issue, and I understood it.
- Your deletions shown in the Files Changed tab look good (including the lines of code that were deleted then added back). I can see the changes in Docker too.
- You checked a box in the the CodeQL Alerts section.
Suggestions
n/a


Please note: You must be a member of the HFLA website team in order to create pull requests. Please see our page on how to join us as a member at HFLA: https://www.hackforla.org/getting-started. Delete this message if you joined this team via onboarding.
Fixes #8109
What changes did you make?
Current Project Teamsection on theCivic Tech JobspageWhy did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied