remove noop get_valid_paths()

also fix staticmethod using self

Author: janosh

atomate/common/firetasks/tests/test_parse_outputs.py

@@ -21,9 +21,6 @@ def __init__(self):
     def assimilate(self, path):
         return {"drone": "Test Drone", "dir_name": "/test", "state": "successful"}
 
-    def get_valid_paths(self, path):
-        return path
-
 
 class TestToDbTask(AtomateTest):
     def test_ToDbTask(self):

atomate/lammps/drones.py

@@ -83,7 +83,7 @@ def assimilate(
         dump_files = [dump_files] if isinstance(dump_files, str) else dump_files
 
         # input set
-        lmps_input = LammpsInputSet.from_file(
+        lmps_input = LammpsInputSet.from_file(  # noqa: F821
             "lammps", input_file, {}, data_file, data_filename
         )
 
@@ -94,7 +94,7 @@ def assimilate(
                 dumps.append((df, LammpsDump.from_file(os.path.join(path, df))))
 
         # log
-        log = LammpsLog(log_file=log_file)
+        log = LammpsLog(log_file=log_file)  # noqa: F821
 
         logger.info(f"Getting task doc for base dir :{path}")
         d = self.generate_doc(path, lmps_input, log, dumps)
@@ -163,9 +163,6 @@ def generate_doc(self, dir_name, lmps_input, log, dumps):
             )
             return None
 
-    def get_valid_paths(self, path):
-        return [path]
-
     def as_dict(self):
         init_args = {
             "additional_fields": self.additional_fields,

atomate/qchem/drones.py

@@ -503,7 +503,3 @@ def validate_doc(self, d):
             diff = v.difference(set(d.get(k, d).keys()))
             if diff:
                 logger.warning(f"The keys {diff} in {k} not set")
-
-    @staticmethod
-    def get_valid_paths(self, path):
-        return [path]

atomate/vasp/firetasks/lobster_tasks.py

@@ -231,7 +231,8 @@ def __init__(self, *args, **kwargs):
                         f"Check that you did not misspell it."
                     )
 
-    def _find_gz_file(self, filename):
+    @staticmethod
+    def _find_gz_file(filename):
         gz_filename = filename + ".gz"
         if os.path.exists(gz_filename):
             return gz_filename