Skip to content

Commit 3766783

Browse files
authored
Merge pull request #752 from acrutt/add_tags_bug
add_tags bug
2 parents da9e6fa + 83ee405 commit 3766783

File tree

1 file changed

+16
-5
lines changed

1 file changed

+16
-5
lines changed

atomate/common/powerups.py

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,14 +61,18 @@ def add_tags(original_wf, tags_list):
6161

6262
# WF metadata
6363
if "tags" in original_wf.metadata:
64-
original_wf.metadata["tags"].extend(tags_list)
64+
for t in tags_list:
65+
if t not in original_wf.metadata["tags"]:
66+
original_wf.metadata["tags"].append(t)
6567
else:
6668
original_wf.metadata["tags"] = tags_list
6769

6870
# FW metadata
6971
for idx_fw in range(len(original_wf.fws)):
7072
if "tags" in original_wf.fws[idx_fw].spec:
71-
original_wf.fws[idx_fw].spec["tags"].extend(tags_list)
73+
for t in tags_list:
74+
if t not in original_wf.fws[idx_fw].spec["tags"]:
75+
original_wf.fws[idx_fw].spec["tags"].append(t)
7276
else:
7377
original_wf.fws[idx_fw].spec["tags"] = tags_list
7478

@@ -77,9 +81,16 @@ def add_tags(original_wf, tags_list):
7781
for idx_fw, idx_t in idxs:
7882
if "additional_fields" in original_wf.fws[idx_fw].tasks[idx_t].optional_params:
7983
if "tags" in original_wf.fws[idx_fw].tasks[idx_t]["additional_fields"]:
80-
original_wf.fws[idx_fw].tasks[idx_t]["additional_fields"][
81-
"tags"
82-
].extend(tags_list)
84+
for t in tags_list:
85+
if (
86+
t
87+
not in original_wf.fws[idx_fw].tasks[idx_t][
88+
"additional_fields"
89+
]["tags"]
90+
):
91+
original_wf.fws[idx_fw].tasks[idx_t]["additional_fields"][
92+
"tags"
93+
].append(t)
8394
else:
8495
original_wf.fws[idx_fw].tasks[idx_t]["additional_fields"][
8596
"tags"

0 commit comments

Comments
 (0)