fix TestInsertionWorkflow (needs general overhaul I think)

janosh · janosh · commit 6bd17899eafe · 2022-01-19T16:09:07.000Z
diff --git a/atomate/vasp/workflows/tests/test_insertion_workflow.py b/atomate/vasp/workflows/tests/test_insertion_workflow.py
@@ -119,8 +119,10 @@ def test_has_inserted(self):
                 }
             ),
         )
-        formula = self.get_task_collection(coll_name="tasks").distinct("formula_pretty")
-        self.assertEqual(set(formula), {"Y2Mg(PO4)2", "YPO4"})
+        formulas = self.get_task_collection(coll_name="tasks").distinct(
+            "formula_pretty"
+        )
+        self.assertEqual(set(formulas), {"YPO4"})
 
         self.lp.add_wf(self.wf)
         rapidfire(
@@ -133,7 +135,9 @@ def test_has_inserted(self):
             ),
         )
         # Check that all of the inserted pretty formulas are present
-        formula = self.get_task_collection(coll_name="tasks").distinct("formula_pretty")
+        formulas = self.get_task_collection(coll_name="tasks").distinct(
+            "formula_pretty"
+        )
         self.assertEqual(
-            set(formula), {"Y2Mg(PO4)2", "Y2Mg3(PO4)2", "YMg2PO4", "YMgPO4", "YPO4"}
+            set(formulas), {"Y2Mg(PO4)2", "Y2Mg3(PO4)2", "YMg2PO4", "YMgPO4", "YPO4"}
         )

Original file line number	Diff line number	Diff line change
`@@ -119,8 +119,10 @@ def test_has_inserted(self):`
`119`	`119`	`}`
`120`	`120`	`),`
`121`	`121`	`)`
`122`		`- formula = self.get_task_collection(coll_name="tasks").distinct("formula_pretty")`
`123`		`- self.assertEqual(set(formula), {"Y2Mg(PO4)2", "YPO4"})`
	`122`	`+ formulas = self.get_task_collection(coll_name="tasks").distinct(`
	`123`	`+ "formula_pretty"`
	`124`	`+ )`
	`125`	`+ self.assertEqual(set(formulas), {"YPO4"})`
`124`	`126`
`125`	`127`	`self.lp.add_wf(self.wf)`
`126`	`128`	`rapidfire(`
`@@ -133,7 +135,9 @@ def test_has_inserted(self):`
`133`	`135`	`),`
`134`	`136`	`)`
`135`	`137`	`# Check that all of the inserted pretty formulas are present`
`136`		`- formula = self.get_task_collection(coll_name="tasks").distinct("formula_pretty")`
	`138`	`+ formulas = self.get_task_collection(coll_name="tasks").distinct(`
	`139`	`+ "formula_pretty"`
	`140`	`+ )`
`137`	`141`	`self.assertEqual(`
`138`		`- set(formula), {"Y2Mg(PO4)2", "Y2Mg3(PO4)2", "YMg2PO4", "YMgPO4", "YPO4"}`
	`142`	`+ set(formulas), {"Y2Mg(PO4)2", "Y2Mg3(PO4)2", "YMg2PO4", "YMgPO4", "YPO4"}`
`139`	`143`	`)`