Skip to content

Commit 7fc95c3

Browse files
authored
Merge pull request #763 from jmmshn/ci_fix
Fix various CI issues
2 parents 4577c94 + 4c0ce2b commit 7fc95c3

File tree

7 files changed

+24
-31
lines changed

7 files changed

+24
-31
lines changed

atomate/vasp/firetasks/electrode_tasks.py

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,7 @@
1010
from atomate.vasp.database import VaspCalcDb
1111
from atomate.vasp.firetasks import pass_vasp_result
1212
from atomate.vasp.fireworks.core import OptimizeFW, StaticFW
13-
14-
try:
15-
from pymatgen.analysis.defects import ChargeInsertionAnalyzer
16-
except ImportError:
17-
print(
18-
"Failed to import ChargeInsertionAnalyzer. This is likely due to converting the pymatgen defects module "
19-
"to a namespace package. See https://github.com/materialsproject/pymatgen/pull/2582#issuecomment-1198318101 "
20-
"for updates."
21-
)
13+
from pymatgen.analysis.defects.utils import ChargeInsertionAnalyzer
2214

2315
__author__ = "Jimmy Shen"
2416
__email__ = "[email protected]"

atomate/vasp/firetasks/write_inputs.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -630,7 +630,6 @@ def run_task(self, fw_spec):
630630
t_cls = None
631631
for m in [
632632
"advanced_transformations",
633-
"defect_transformations",
634633
"site_transformations",
635634
"standard_transformations",
636635
]:
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
Si2
22
1.0
3-
3.840198 0.000000 0.000000
4-
1.920099 3.325710 0.000000
5-
0.000000 -2.217138 3.135509
3+
3.8401979336999998 0.0000000000000000 0.0000000000000000
4+
1.9200989667999999 3.3257101909000002 0.0000000000000000
5+
0.0000000000000000 -2.2171384942999999 3.1355090603000000
66
Si
77
2
88
direct
9-
0.000000 0.000000 0.000000 Si
10-
0.750000 0.500000 0.750000 Si
9+
0.0000000000000000 0.0000000000000000 0.0000000000000000 Si
10+
0.7500000000000000 0.5000000000000000 0.7500000000000000 Si

atomate/vasp/tests/test_setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import os
2+
from turtle import pos
23
import unittest
34

45
from pymatgen.core import IStructure, Lattice

requirements-ci.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
boto3==1.17.97
1+
Flask==2.1.3
22
coverage==5.5
3-
moto==2.0.10
3+
moto==3.1.18
44
pytest-cov==2.12.1
55
pytest==6.2.4

requirements.txt

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
custodian==2022.5.26
22
FireWorks==2.0.3
3-
maggma==0.44.0
4-
monty==2021.6.10
5-
networkx==2.5.1
6-
numpy
7-
pandas==1.2.5
8-
paramiko==2.10.1
9-
pydash==5.0.0
10-
pymatgen-analysis-diffusion
11-
pymatgen
12-
pymongo
13-
pyyaml==5.4.1
14-
ruamel.yaml==0.17.9
15-
scipy==1.7.2
16-
tqdm==4.61.1
3+
maggma==0.48.1
4+
monty==2022.9.9
5+
networkx==2.8.6
6+
numpy==1.23.3
7+
pandas==1.4.4
8+
paramiko==2.11.0
9+
pydash==5.1.0
10+
pymatgen-analysis-diffusion==2022.7.21
11+
pymatgen-analysis-defects==2022.9.14
12+
pymatgen==2022.9.8
13+
pymongo==4.2.0
14+
ruamel.yaml==0.17.21
15+
scipy==1.9.1
16+
tqdm==4.64.1

setup.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
"paramiko",
3434
"pydash>=4.1.0",
3535
"pymatgen-analysis-diffusion",
36+
"pymatgen-analysis-defects>=2022.9.14",
3637
"pymatgen",
3738
"pymongo",
3839
"pyyaml>=5.1.2",

0 commit comments

Comments
 (0)