remove few more os.path.join() noops

Author: janosh

atomate/common/firetasks/glue_tasks.py

@@ -231,7 +231,7 @@ def run_task(self, fw_spec):
         if self.get("relative_path", True):
             new_dir = os.path.join(os.getcwd(), self["folder_name"])
         else:
-            new_dir = os.path.join(self["folder_name"])
+            new_dir = self["folder_name"]
         if not os.path.exists(new_dir):
             os.makedirs(new_dir)
         if self.get("change_dir", False):

atomate/utils/tests/test_loaders.py

@@ -8,15 +8,15 @@
 
 # TODO: @computron - move this test if you also move the loader code -computron
 
+module_dir = os.path.dirname(os.path.abspath(__file__))
+
 
 class FuncTest(PymatgenTest):
     def setUp(self):
         self.structure = PymatgenTest.get_structure("Si")
 
     def test_get_wf_from_spec_dict(self):
-        d = loadfn(
-            os.path.join(os.path.abspath(os.path.dirname(__file__)), "spec.yaml")
-        )
+        d = loadfn(os.path.join(module_dir, "spec.yaml"))
         wf = get_wf_from_spec_dict(self.structure, d)
         self.assertEqual(len(wf.fws), 4)
         for f in wf.fws:
@@ -25,16 +25,12 @@ def test_get_wf_from_spec_dict(self):
         self.assertEqual(sorted(len(v) for v in wf.links.values()), [0, 0, 1, 2])
 
         self.assertEqual(wf.name, "Si:band structure")
-        d = loadfn(
-            os.path.join(os.path.abspath(os.path.dirname(__file__)), "badspec.yaml")
-        )
+        d = loadfn(os.path.join(module_dir, "badspec.yaml"))
 
         self.assertRaises(ImportError, get_wf_from_spec_dict, self.structure, d)
 
     def test_multi_parent(self):
-        d = loadfn(
-            os.path.join(os.path.abspath(os.path.dirname(__file__)), "spec_multi.yaml")
-        )
+        d = loadfn(os.path.join(module_dir, "spec_multi.yaml"))
         wf = get_wf_from_spec_dict(self.structure, d)
         self.assertEqual(len(wf.fws), 3)
         self.assertEqual(sorted(len(v) for v in wf.links.values()), [0, 1, 1])

scripts/atwf

@@ -35,7 +35,7 @@ common_params:
   db_file: None
 """
 
-presets_dir = os.path.join(os.path.dirname(os.path.abspath(core.__file__)))
+presets_dir = os.path.dirname(os.path.abspath(core.__file__))
 lpad = LaunchPad.auto_load()