Skip to content

Commit 05f17d4

Browse files
committed
Move emailing to the member as last operation since that cannot be rolled back
1 parent 497b1c9 commit 05f17d4

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

project/examples/handlers.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,6 @@ def on_approved(self, application, member):
4343
msg = "on_approved called for %s" % application
4444
logger.info(msg)
4545
print(msg)
46-
mail = EmailMessage()
47-
mail.to = [member.email, ]
48-
mail.body = """Your membership has been approved, your member id is #%d""" % member.member_id
49-
mail.send()
5046

5147
# Auto-add the membership fee as recurring transaction
5248
membership_fee = env.float('MEMBEREXAMPLE_MEMBERSHIP_FEE', default=None)
@@ -73,6 +69,11 @@ def on_approved(self, application, member):
7369
mail.body = 'subscribe'
7470
mail.send()
7571

72+
mail = EmailMessage()
73+
mail.to = [member.email, ]
74+
mail.body = """Your membership has been approved, your member id is #%d""" % member.member_id
75+
mail.send()
76+
7677

7778
class TransactionHandler(BaseTransactionHandler):
7879

0 commit comments

Comments
 (0)