Implement the sync

Author: rambo

project/slacksync/management/commands/sync_slack_users.py

@@ -1,12 +1,28 @@
 # -*- coding: utf-8 -*-
 from django.core.management.base import BaseCommand, CommandError
+from slacksync.membersync import SlackMemberSync
+from slacksync.utils import api_configured
 
 
 class Command(BaseCommand):
     help = 'Make sure all members are in Slack and optionally kick non-members'
 
     def add_arguments(self, parser):
+        parser.add_argument('--autodeactivate', action='store_true', help='Automatically deactivate users that are no longer members')
+
         pass
 
     def handle(self, *args, **options):
-        raise NotImplemented()
+        if not api_configured():
+            raise CommandError("API not configured")
+        autoremove = False
+        if options['autodeactivate']:
+            autoremove = True
+        sync = SlackMemberSync(autoremove)
+        tbd = sync.sync_members()
+        if options['verbosity'] > 1:
+            for dm in tbd:
+                if autoremove:
+                    print("User {uid} ({email}) was removed".format(uid=dm[0], email=dm[1]))
+                else:
+                    print("User {uid} ({email}) should be removed".format(uid=dm[0], email=dm[1]))

project/slacksync/membersync.py

@@ -1,15 +1,21 @@
 # -*- coding: utf-8 -*-
+import logging
+import time
+
 from django.conf import settings
-from members.objects import Member
+from members.models import Member
 from requests.sessions import Session
 
 from .utils import api_configured, get_client
 
-logger = logger.getLogger()
+logger = logging.getLogger()
 
 
 class SlackMemberSync(object):
+    """Sync members and slack members"""
+
     def get_slack_users_simple(self, slack, exclude_api_user=True):
+        """Get just the properties we need from the slack members list"""
         response = slack.users.list()
         emails = []
         for member in response.body['members']:
@@ -24,16 +30,43 @@ def get_slack_users_simple(self, slack, exclude_api_user=True):
     def sync_members(self, autodeactivate=False):
         """Sync members, NOTE: https://github.com/ErikKalkoken/slackApiDoc/blob/master/users.admin.setInactive.md says 
         deactivation via API works only on paid tiers"""
+        if not api_configured():
+            raise RuntimeError("Slack API not configured")
         with Session() as session:
             slack = get_client(session=session)
             slack_users = self.get_slack_users_simple(slack)
-            slac_emails = [x[2] for x in slack_users]
+            slack_emails = set([x[2] for x in slack_users])
             add_members = Member.objects.exclude(email__in=slack_emails)
             for member in add_members:
                 try:
                     resp = slack.users.admin.invite(member.email)
                     if 'ok' not in resp.body or not resp.body['ok']:
                         self.logger.error("Could not invite {}, response: {}".format(member.email, response.body))
+                    time.sleep(0.1)  # rate-limit
                 except Exception as e:
                     logger.exception("Got exception when trying to invite {}".format(member.email))
-            # TODO: check which members should be removed
+
+            member_emails = set(Member.objects.values_list('email', flat=True))
+            remove_slack_emails = slack_emails - member_emails
+            remove_usernames = []
+            if not remove_slack_emails:
+                return remove_usernames
+
+            usernames_by_email = {x[2]: x[1] for x in slack_users}
+            remove_usernames = [(usernames_by_email[x], x) for x in remove_slack_emails]
+
+            if not autodeactivate:
+                return remove_usernames
+
+            userids_by_email = {x[2]: x[0] for x in slack_users}
+            for email in remove_slack_emails:
+                try:
+                    resp = slack.users.admin.setInactive(userids_by_email[email])
+                    if 'ok' not in resp.body or not resp.body['ok']:
+                        self.logger.error(
+                            "Could not deactivate {}, response: {}".format(email, response.body))
+                    time.sleep(0.1)  # rate-limit
+                except Exception as e:
+                    logger.exception("Got exception when trying to deactivate {}".format(email))
+
+            return remove_usernames

project/slacksync/utils.py

@@ -1,13 +1,35 @@
 # -*- coding: utf-8 -*-
+import logging
+
 from django.conf import settings
 from slacker import Slacker
 
+logger = logging.getLogger()
+
 
 def api_configured():
+    """Check that Slack API settings are configured"""
     return bool(settings.SLACK_APIKEY) and bool(settings.SLACK_API_USERNAME)
 
 
 def get_client(**kwargs):
+    """Get a Slacker instance"""
     if not api_configured():
         return False
     return Slacker(settings.SLACK_APIKEY, **kwargs)
+
+
+def quick_invite(email):
+    """Quickly invite single email"""
+    if not api_configured():
+        return False
+    slack = get_client()
+    try:
+        resp = slack.users.admin.invite(member.email)
+        if 'ok' not in resp.body or not resp.body['ok']:
+            self.logger.error("Could not invite {}, response: {}".format(email, response.body))
+            return False
+    except Exception as e:
+        logger.exception("Got exception when trying to invite {}".format(email))
+        return False
+    return True