[vim bindings] Remove dead code and initialize a property

Dominator008 · marijnh · commit c3d22466ca87 · 2016-03-28T20:30:18.000+02:00
The Error after the while(true) loop is not reachable and should
be removed. The "this.iterator" property should be given an
initial value of 0. This fixes two warnings reported by Closure
Compiler.
diff --git a/keymap/vim.js b/keymap/vim.js
@@ -1048,7 +1048,7 @@
     };
     function HistoryController() {
         this.historyBuffer = [];
-        this.iterator;
+        this.iterator = 0;
         this.initialPrefix = null;
     }
     HistoryController.prototype = {
@@ -3290,8 +3290,6 @@
         line = cm.getLine(lineNum);
         pos = (dir > 0) ? 0 : line.length;
       }
-      // Should never get here.
-      throw new Error('The impossible happened.');
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -1048,7 +1048,7 @@`
`1048`	`1048`	`};`
`1049`	`1049`	`function HistoryController() {`
`1050`	`1050`	`this.historyBuffer = [];`
`1051`		`- this.iterator;`
	`1051`	`+ this.iterator = 0;`
`1052`	`1052`	`this.initialPrefix = null;`
`1053`	`1053`	`}`
`1054`	`1054`	`HistoryController.prototype = {`
`@@ -3290,8 +3290,6 @@`
`3290`	`3290`	`line = cm.getLine(lineNum);`
`3291`	`3291`	`pos = (dir > 0) ? 0 : line.length;`
`3292`	`3292`	`}`
`3293`		`- // Should never get here.`
`3294`		`- throw new Error('The impossible happened.');`
`3295`	`3293`	`}`
`3296`	`3294`
`3297`	`3295`	`/**`