[show-hint addon] Fix selected-option background size for scrolling widget

marijnh · marijnh · commit df3a0ae0fb78 · 2016-05-26T09:54:05.000+02:00
diff --git a/addon/hint/show-hint.css b/addon/hint/show-hint.css
@@ -16,6 +16,7 @@
   background: white;
   font-size: 90%;
   font-family: monospace;
+  max-width: 19em;
 
   max-height: 20em;
   overflow-y: auto;
@@ -25,7 +26,6 @@
   margin: 0;
   padding: 0 4px;
   border-radius: 2px;
-  max-width: 19em;
   white-space: pre;
   color: black;
   cursor: pointer;
diff --git a/addon/hint/show-hint.js b/addon/hint/show-hint.js
@@ -254,7 +254,8 @@
       }
       hints.style.left = (left = pos.left - overlapX) + "px";
     }
-    if (scrolls) hints.style.paddingRight = cm.display.nativeBarWidth + "px"
+    if (scrolls) for (var node = hints.firstChild; node; node = node.nextSibling)
+      node.style.paddingRight = cm.display.nativeBarWidth + "px"
 
     cm.addKeyMap(this.keyMap = buildKeyMap(completion, {
       moveFocus: function(n, avoidWrap) { widget.changeActive(widget.selectedHint + n, avoidWrap); },

Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,8 @@`
`254`	`254`	`}`
`255`	`255`	`hints.style.left = (left = pos.left - overlapX) + "px";`
`256`	`256`	`}`
`257`		`- if (scrolls) hints.style.paddingRight = cm.display.nativeBarWidth + "px"`
	`257`	`+ if (scrolls) for (var node = hints.firstChild; node; node = node.nextSibling)`
	`258`	`+ node.style.paddingRight = cm.display.nativeBarWidth + "px"`
`258`	`259`
`259`	`260`	`cm.addKeyMap(this.keyMap = buildKeyMap(completion, {`
`260`	`261`	`moveFocus: function(n, avoidWrap) { widget.changeActive(widget.selectedHint + n, avoidWrap); },`