Skip to content

Commit 1c38d24

Browse files
authored
Merge pull request #1518 from hackmdio/feat/node-10-build
Change to use nodejs 10.20.1
2 parents 168fdf3 + 41519b1 commit 1c38d24

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

deployments/Dockerfile

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
FROM hackmdio/buildpack:1.0.4 as BUILD
1+
ARG RUNTIME
2+
3+
FROM hackmdio/buildpack:node-10-0baafb79 as BUILD
24

35
COPY --chown=hackmd:hackmd . .
46

@@ -12,11 +14,12 @@ RUN set -xe && \
1214
rm -rf .git .gitignore .travis.yml .dockerignore .editorconfig .babelrc .mailmap .sequelizerc.example \
1315
test docs contribute \
1416
package-lock.json webpack.prod.js webpack.htmlexport.js webpack.dev.js webpack.common.js \
15-
config.json.example README.md CONTRIBUTING.md AUTHORS
17+
config.json.example README.md CONTRIBUTING.md AUTHORS node_modules
1618

17-
FROM hackmdio/runtime:1.0.6
19+
FROM $RUNTIME
1820
USER hackmd
1921
WORKDIR /home/hackmd/app
2022
COPY --chown=1500:1500 --from=BUILD /home/hackmd/app .
23+
RUN npm install --production && npm cache clean --force && rm -rf /tmp/{core-js-banners,phantomjs}
2124
EXPOSE 3000
2225
ENTRYPOINT ["/home/hackmd/app/docker-entrypoint.sh"]

deployments/build.sh

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
#!/usr/bin/env bash
22

3+
set -euo pipefail
4+
set -x
5+
36
CURRENT_DIR=$(dirname "$BASH_SOURCE")
47

5-
docker build -t hackmdio/codimd -f "$CURRENT_DIR/Dockerfile" "$CURRENT_DIR/.."
8+
GIT_SHA1="$(git rev-parse HEAD)"
9+
GIT_SHORT_ID="${GIT_SHA1:0:8}"
10+
GIT_TAG=$(git describe --exact-match --tags $(git log -n1 --pretty='%h') 2>/dev/null || echo "")
11+
12+
DOCKER_TAG="${GIT_TAG:-$GIT_SHORT_ID}"
13+
14+
docker build --build-arg RUNTIME=hackmdio/runtime:node-10-0baafb79 -t "hackmdio/hackmd:$DOCKER_TAG" -f "$CURRENT_DIR/Dockerfile" "$CURRENT_DIR/.."
15+
16+
docker build --build-arg RUNTIME=hackmdio/runtime:node-10-cjk-0baafb79 -t "hackmdio/hackmd:$DOCKER_TAG-cjk" -f "$CURRENT_DIR/Dockerfile" "$CURRENT_DIR/.."

0 commit comments

Comments
 (0)