Skip to content

Commit 2c31b8d

Browse files
committed
Fixed realtime cleaner, socket should defined and notename is not a necessary in disconnect
1 parent ab6d6c7 commit 2c31b8d

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

lib/realtime.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ var updater = setInterval(function () {
107107
var cleaner = setInterval(function () {
108108
async.each(Object.keys(users), function (key, callback) {
109109
var socket = realtime.io.sockets.connected[key];
110-
if (!socket || !socket.rooms || socket.rooms.length <= 0) {
110+
if (socket && (!socket.rooms || socket.rooms.length <= 0)) {
111111
if (config.debug)
112112
logger.info("cleaner found redundant user: " + key);
113113
disconnectSocketQueue.push(socket);
@@ -353,14 +353,11 @@ function disconnect(socket) {
353353
logger.info("SERVER disconnected a client");
354354
logger.info(JSON.stringify(users[socket.id]));
355355
}
356-
var notename = getNotenameFromSocket(socket);
357-
if (!notename) {
358-
isDisconnectBusy = false;
359-
return;
360-
}
356+
361357
if (users[socket.id]) {
362358
delete users[socket.id];
363359
}
360+
var notename = getNotenameFromSocket(socket);
364361
var note = notes[notename];
365362
if (note) {
366363
delete note.users[socket.id];

0 commit comments

Comments
 (0)