Merge pull request #1500 from ldruschk/fix-internal-server-error-freeurl-not-logged-in

a60814billy · web-flow · commit a6c7582aa2d0 · 2020-05-11T16:05:20.000+08:00
return errorForbidden when anonymous user tries to create freeUrl pad
diff --git a/lib/note/index.js b/lib/note/index.js
@@ -61,6 +61,8 @@ async function showNote (req, res) {
     // if allow free url enable, auto create note
     if (!config.allowFreeURL || config.forbiddenNoteIDs.includes(noteId)) {
       return errorNotFound(req, res)
+    } else if (!config.allowAnonymous && !userId) {
+      return errorForbidden(req, res)
     }
     note = await createNote(userId, noteId)
   }

Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,8 @@ async function showNote (req, res) {`
`61`	`61`	`// if allow free url enable, auto create note`
`62`	`62`	`if (!config.allowFreeURL \|\| config.forbiddenNoteIDs.includes(noteId)) {`
`63`	`63`	`return errorNotFound(req, res)`
	`64`	`+ } else if (!config.allowAnonymous && !userId) {`
	`65`	`+ return errorForbidden(req, res)`
`64`	`66`	`}`
`65`	`67`	`note = await createNote(userId, noteId)`
`66`	`68`	`}`