Skip to content

Commit dba9575

Browse files
authored
Merge pull request #1112 from hackmdio/fix-XSS-issues
Fix some XSS issues
2 parents f9cc2ff + 067cfe2 commit dba9575

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

public/js/render.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ var filterXSSOptions = {
4545
// allow comment tag
4646
if (tag === '!--') {
4747
// do not filter its attributes
48-
return html
48+
return html.replace(/<(?!!--)/g, '&lt;').replace(/-->/g, '__HTML_COMMENT_END__').replace(/>/g, '&gt;').replace(/__HTML_COMMENT_END__/g, '-->')
4949
}
5050
},
5151
onTagAttr: function (tag, name, value, isWhiteAttr) {

public/views/shared/disqus.ejs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ var disqus_config = function () {
55
};
66
(function() {
77
var d = document, s = d.createElement('script');
8-
s.src = 'https://<%= disqus %>.disqus.com/embed.js';
8+
s.src = 'https://<%= disqus.replace(/[^A-Za-z0-9]+/g, '') %>.disqus.com/embed.js';
99
s.setAttribute('data-timestamp', +new Date());
1010
(d.head || d.body).appendChild(s);
1111
})();

0 commit comments

Comments
 (0)