Skip to content

Commit 75a4410

Browse files
HCK-12404: fix Delta Model - missing SQL for entity property changes (#154)
* HCK-12458: Fix order of ALTER script statements for keys * fix: order * fix order * ашч
1 parent 6a88d59 commit 75a4410

File tree

2 files changed

+16
-7
lines changed

2 files changed

+16
-7
lines changed

forward_engineering/alterScript/alterScriptFromDeltaHelper.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ const {
1111
getDeleteColumnScriptDtos,
1212
getModifyColumnScriptDtos,
1313
getModifyCollectionScriptDtos,
14+
getModifyCollectionKeysScriptDtos,
1415
} = require('./alterScriptHelpers/alterEntityHelper');
1516
const {
1617
getDeleteUdtScriptDto,
@@ -111,6 +112,7 @@ const getAlterCollectionsScriptDtos = ({
111112
.map(getDeleteCollectionScriptDto(app));
112113

113114
const modifyCollectionScriptDtos = modifyScriptsData.flatMap(getModifyCollectionScriptDtos({ dbVersion }));
115+
const modifyCollectionKeysScriptDtos = modifyScriptsData.flatMap(getModifyCollectionKeysScriptDtos({ dbVersion }));
114116

115117
const addColumnScriptDtos = createScriptsData
116118
.filter(item => !item?.compMod?.created)
@@ -131,6 +133,7 @@ const getAlterCollectionsScriptDtos = ({
131133
...deleteCollectionScriptDtos,
132134
...modifyCollectionScriptDtos,
133135
...addColumnScriptDtos,
136+
...modifyCollectionKeysScriptDtos,
134137
...deleteColumnScriptDtos,
135138
...modifyColumnScriptDtos,
136139
].filter(Boolean);

forward_engineering/alterScript/alterScriptHelpers/alterEntityHelper.js

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -88,19 +88,24 @@ const getModifyCollectionScriptDtos =
8888
collection => {
8989
const modifyCheckConstraintScriptDtos = getModifyCheckConstraintScriptDtos(collection);
9090
const modifyCommentScriptDtos = getModifyEntityCommentsScriptDtos(collection);
91+
return [...modifyCheckConstraintScriptDtos, ...modifyCommentScriptDtos].filter(Boolean);
92+
};
93+
94+
/**
95+
* @return {(collection: AlterCollectionDto) => AlterScriptDto[]}
96+
* */
97+
const getModifyCollectionKeysScriptDtos =
98+
({ dbVersion }) =>
99+
collection => {
91100
const modifyPKConstraintDtos = getModifyPkConstraintsScriptDtos(collection);
92101
const modifyUniqueKeyConstraintDtos = getModifyUniqueKeyConstraintsScriptDtos({
93102
collection,
94103
dbVersion,
95104
});
96105
const modifyIndexesScriptDtos = getModifyIndexesScriptDtos({ collection, dbVersion });
97-
return [
98-
...modifyCheckConstraintScriptDtos,
99-
...modifyCommentScriptDtos,
100-
...modifyPKConstraintDtos,
101-
...modifyUniqueKeyConstraintDtos,
102-
...modifyIndexesScriptDtos,
103-
].filter(Boolean);
106+
return [...modifyPKConstraintDtos, ...modifyUniqueKeyConstraintDtos, ...modifyIndexesScriptDtos].filter(
107+
Boolean,
108+
);
104109
};
105110

106111
/**
@@ -298,4 +303,5 @@ module.exports = {
298303
getAddColumnScriptDtos,
299304
getDeleteColumnScriptDtos,
300305
getModifyColumnScriptDtos,
306+
getModifyCollectionKeysScriptDtos,
301307
};

0 commit comments

Comments
 (0)