Skip to content

Commit 8c67e44

Browse files
authored
Merge pull request #83 from hackolade/feature/HCK-4305-hackolade-re-comments-of-functions-are-not-generated-in-the-ddl
HCK-4305: add comments for functions in FE-d DDL script
2 parents 3a55c56 + 6533518 commit 8c67e44

File tree

2 files changed

+19
-3
lines changed

2 files changed

+19
-3
lines changed

forward_engineering/ddlProvider/ddlHelpers/functionHelper.js

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,15 @@
1-
module.exports = ({ _, templates, assignTemplates, getFunctionArguments, getNamePrefixedWithSchemaName }) => {
1+
module.exports = ({
2+
_,
3+
templates,
4+
assignTemplates,
5+
getFunctionArguments,
6+
getNamePrefixedWithSchemaName,
7+
wrapComment,
8+
}) => {
29
const getFunctionsScript = (schemaName, udfs) => {
310
return _.map(udfs, udf => {
411
const orReplace = udf.functionOrReplace ? ' OR REPLACE' : '';
5-
6-
return assignTemplates(templates.createFunction, {
12+
const createFunctionStatement = assignTemplates(templates.createFunction, {
713
name: getNamePrefixedWithSchemaName(udf.name, schemaName),
814
orReplace: orReplace,
915
parameters: getFunctionArguments(udf.functionArguments),
@@ -12,6 +18,15 @@ module.exports = ({ _, templates, assignTemplates, getFunctionArguments, getName
1218
properties: getProperties(udf),
1319
definition: udf.functionBody,
1420
});
21+
const commentOnFunction = udf.functionDescription
22+
? assignTemplates(templates.comment, {
23+
object: 'FUNCTION',
24+
objectName: getNamePrefixedWithSchemaName(udf.name, schemaName),
25+
comment: wrapComment(udf.functionDescription),
26+
})
27+
: '';
28+
29+
return [createFunctionStatement, commentOnFunction].filter(Boolean).join('\n');
1530
}).join('\n');
1631
};
1732

forward_engineering/ddlProvider/ddlProvider.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ module.exports = (baseProvider, options, app) => {
4545
assignTemplates,
4646
getFunctionArguments,
4747
getNamePrefixedWithSchemaName,
48+
wrapComment,
4849
});
4950

5051
const { getProceduresScript } = require('./ddlHelpers/procedureHelper')({

0 commit comments

Comments
 (0)