RE: fix reversing views with prohibited symbols in name

Author: serhii-filonenko

reverse_engineering/helpers/postgresHelpers/common.js

@@ -1,3 +1,101 @@
+const POSTGRES_RESERVED_WORDS = [
+	'ALL',
+	'ANALYSE',
+	'ANALYZE',
+	'AND',
+	'ANY',
+	'ARRAY',
+	'ASC',
+	'ASYMMETRIC',
+	'AUTHORIZATION',
+	'BINARY',
+	'BOTH',
+	'CASE',
+	'CAST',
+	'CHECK',
+	'COLLATE',
+	'COLUMN',
+	'CONCURRENTLY',
+	'CONSTRAINT',
+	'CREATE',
+	'CROSS',
+	'CURRENT_CATALOG',
+	'CURRENT_DATE',
+	'CURRENT_ROLE',
+	'CURRENT_SCHEMA',
+	'CURRENT_TIME',
+	'CURRENT_TIMESTAMP',
+	'CURRENT_USER',
+	'DEFAULT',
+	'DEFERRABLE',
+	'DESC',
+	'DISTINCT',
+	'DO',
+	'ELSE',
+	'END',
+	'EXCEPT',
+	'FALSE',
+	'FOR',
+	'FOREIGN',
+	'FREEZE',
+	'FROM',
+	'FULL',
+	'GRANT',
+	'GROUP',
+	'HAVING',
+	'ILIKE',
+	'IN',
+	'INITIALLY',
+	'INTERSECT',
+	'INTO',
+	'IS',
+	'ISNULL',
+	'JOIN',
+	'LATERAL',
+	'LEADING',
+	'LEFT',
+	'LIKE',
+	'LIMIT',
+	'LOCALTIME',
+	'LOCALTIMESTAMP',
+	'NATURAL',
+	'NOT',
+	'NULL',
+	'OFFSET',
+	'ON',
+	'ONLY',
+	'OR',
+	'ORDER',
+	'OUTER',
+	'OVERLAPS',
+	'PLACING',
+	'PRIMARY',
+	'REFERENCES',
+	'RETURNING',
+	'RIGHT',
+	'SELECT',
+	'SESSION_USER',
+	'SIMILAR',
+	'SOME',
+	'SYMMETRIC',
+	'TABLE',
+	'TABLESAMPLE',
+	'THEN',
+	'TO',
+	'TRAILING',
+	'TRUE',
+	'UNION',
+	'UNIQUE',
+	'USER',
+	'USING',
+	'VARIADIC',
+	'VERBOSE',
+	'WHEN',
+	'WHERE',
+	'WINDOW',
+	'WITH',
+];
+
 let _ = null;
 
 const setDependencies = app => {
@@ -12,9 +110,12 @@ const clearEmptyPropertiesInObject = obj =>
 		.value();
 
 const getColumnNameByPosition = columns => position => _.find(columns, { ordinal_position: position })?.column_name;
+const wrapInQuotes = name =>
+	/\s|\W/.test(name) || _.includes(POSTGRES_RESERVED_WORDS, _.toUpper(name)) ? `"${name}"` : name;
 
 module.exports = {
 	clearEmptyPropertiesInObject,
 	setDependencies,
 	getColumnNameByPosition,
+	wrapInQuotes,
 };

reverse_engineering/helpers/postgresHelpers/viewHelper.js

@@ -1,4 +1,4 @@
-const { clearEmptyPropertiesInObject } = require('./common');
+const { clearEmptyPropertiesInObject, wrapInQuotes } = require('./common');
 
 let _ = null;
 
@@ -20,7 +20,7 @@ const generateCreateViewScript = (viewName, viewData, viewDefinitionFallback = {
 		return '';
 	}
 
-	return `CREATE VIEW ${viewName} AS ${selectStatement}`;
+	return `CREATE VIEW ${wrapInQuotes(viewName)} AS ${selectStatement}`;
 };
 
 const prepareViewData = (viewData, viewOptions, triggers) => {