Fix empty Target JAS Results

Author: hadarshjfrog

utils/results/common.go

@@ -78,6 +78,16 @@ func CheckIfFailBuild(auditResults *SecurityCommandResults) (bool, error) {
 }
 
 func checkIfFailBuildConsideringApplicability(target *TargetResults, entitledForJas bool, shouldFailBuild *bool) error {
+	if target == nil {
+		log.Debug("checkIfFailBuildConsideringApplicability: target is nil, returning early")
+		return nil
+	}
+	if target.JasResults == nil {
+		log.Debug(fmt.Sprintf("checkIfFailBuildConsideringApplicability: JasResults is nil for target %s, falling back to check without applicability", target.ScanTarget.Target))
+		*shouldFailBuild = checkIfFailBuildWithoutConsideringApplicability(target)
+		return nil
+	}
+
 	jasApplicabilityResults := target.JasResults.GetApplicabilityScanResults()
 
 	if target.ScaResults == nil {

utils/results/common_test.go

@@ -183,6 +183,30 @@ func TestViolationFailBuild(t *testing.T) {
 			},
 			expectedResult: false,
 		},
+		{
+			name: "nil JasResults with violations - should fallback to check without applicability",
+			auditResults: &SecurityCommandResults{
+				EntitledForJas: true,
+				Targets: []*TargetResults{
+					{
+						ScanTarget: ScanTarget{Target: "test-target"},
+						ScaResults: &ScaScanResults{
+							Violations: []services.Violation{
+								{
+									Components:    map[string]services.Component{"gav://antparent:ant:1.6.5": {}},
+									ViolationType: utils.ViolationTypeSecurity.String(),
+									FailBuild:     true,
+									Cves:          []services.Cve{{Id: "CVE-2024-1234"}},
+									Severity:      "High",
+								},
+							},
+						},
+						JasResults: nil,
+					},
+				},
+			},
+			expectedResult: true, // Should fail because violation has FailBuild=true
+		},
 	}
 
 	for _, test := range tests {