Fix audit diff err when target to compare not found (jfrog#499)

Author: attiasas

commands/audit/audit.go

@@ -375,19 +375,14 @@ func populateScanTargets(cmdResults *results.SecurityCommandResults, params *Aud
 			// No need to generate the SBOM if we are not going to use it.
 			continue
 		}
-		targetResultsToCompare, err := getTargetResultsToCompare(cmdResults, params.ResultsToCompare(), targetResult)
-		if err != nil {
-			cmdResults.AddGeneralError(fmt.Errorf("failed to get target results to compare: %s", err.Error()), false)
-			continue
-		}
 		bom.GenerateSbomForTarget(params.BomGenerator().WithOptions(buildinfo.WithDescriptors(targetResult.GetDescriptors())),
 			bom.SbomGeneratorParams{
 				Target:               targetResult,
 				AllowPartialResults:  params.AllowPartialResults(),
 				ScanResultsOutputDir: params.scanResultsOutputDir,
 				// Diff mode - SCA
 				DiffMode:              params.DiffMode(),
-				TargetResultToCompare: targetResultsToCompare,
+				TargetResultToCompare: getTargetResultsToCompare(cmdResults, params.ResultsToCompare(), targetResult),
 			},
 		)
 	}
@@ -399,16 +394,18 @@ func populateScanTargets(cmdResults *results.SecurityCommandResults, params *Aud
 	log.Info(fmt.Sprintf("Performing scans on %d targets:\n%s", len(cmdResults.Targets), scanInfo))
 }
 
-func getTargetResultsToCompare(cmdResults, resultsToCompare *results.SecurityCommandResults, targetResult *results.TargetResults) (targetResultsToCompare *results.TargetResults, err error) {
+func getTargetResultsToCompare(cmdResults, resultsToCompare *results.SecurityCommandResults, targetResult *results.TargetResults) (targetResultsToCompare *results.TargetResults) {
 	if resultsToCompare == nil {
 		return
 	}
 	targetResultsToCompare = results.SearchTargetResultsByRelativePath(
 		utils.GetRelativePath(targetResult.Target, cmdResults.GetCommonParentPath()),
 		resultsToCompare,
 	)
+	// Let's check if the target results to compare are valid.
+	// If the current target result is a new module, it will not have any previous target results to compare with.
 	if targetResultsToCompare == nil || targetResultsToCompare.ScaResults == nil || targetResultsToCompare.ScaResults.Sbom == nil {
-		err = fmt.Errorf("no target results found to compare")
+		log.Debug(fmt.Sprintf("No previous target results found to compare with for %s", targetResult.Target))
 	}
 	return
 }

jas/analyzermanager.go

@@ -25,7 +25,7 @@ import (
 const (
 	ApplicabilityFeatureId                    = "contextual_analysis"
 	AnalyzerManagerZipName                    = "analyzerManager.zip"
-	defaultAnalyzerManagerVersion             = "1.21.4"
+	defaultAnalyzerManagerVersion             = "1.22.0"
 	analyzerManagerDownloadPath               = "xsc-gen-exe-analyzer-manager-local/v1"
 	analyzerManagerDirName                    = "analyzerManager"
 	analyzerManagerExecutableName             = "analyzerManager"