fail build even if vuln was provided

hadarshjfrog · hadarshjfrog · commit cefe5e2139ed · 2025-03-31T23:10:37.000+03:00
diff --git a/commands/scan/scan.go b/commands/scan/scan.go
@@ -269,9 +269,8 @@ func (scanCmd *ScanCommand) RunAndRecordResults(cmdType utils.CommandType, recor
 	if err = cmdResults.GetErrors(); err != nil {
 		return
 	}
-	// If includeVulnerabilities is false it means that context was provided, so we need to check for build violations.
 	// If user provided --fail=false, don't fail the build.
-	if scanCmd.fail && !scanCmd.resultsContext.IncludeVulnerabilities {
+	if scanCmd.fail {
 		if results.CheckIfFailBuild(cmdResults.GetScaScansXrayResults()) {
 			return results.NewFailBuildError()
 		}

Original file line number	Diff line number	Diff line change
`@@ -269,9 +269,8 @@ func (scanCmd *ScanCommand) RunAndRecordResults(cmdType utils.CommandType, recor`
`269`	`269`	`if err = cmdResults.GetErrors(); err != nil {`
`270`	`270`	`return`
`271`	`271`	`}`
`272`		`- // If includeVulnerabilities is false it means that context was provided, so we need to check for build violations.`
`273`	`272`	`// If user provided --fail=false, don't fail the build.`
`274`		`- if scanCmd.fail && !scanCmd.resultsContext.IncludeVulnerabilities {`
	`273`	`+ if scanCmd.fail {`
`275`	`274`	`if results.CheckIfFailBuild(cmdResults.GetScaScansXrayResults()) {`
`276`	`275`	`return results.NewFailBuildError()`
`277`	`276`	`}`