Skip to content

Commit cba8c07

Browse files
committed
a follow-up PR for SmartThingsCommunity#2468 that removes the no longer needed code from init
1 parent 4524087 commit cba8c07

File tree

3 files changed

+2
-13
lines changed

3 files changed

+2
-13
lines changed

drivers/SmartThings/zigbee-switch/src/aqara-light/init.lua

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -54,18 +54,9 @@ local function set_level_handler(driver, device, cmd)
5454
device:send(Level.commands.MoveToLevelWithOnOff(device, level, dimming_rate))
5555
end
5656

57-
local function init(self, device)
58-
local value = { minimum = 2700, maximum = 6000 }
59-
if device:get_model() == "lumi.light.cwacn1" then
60-
value.maximum = 6500
61-
end
62-
emit_event_if_latest_state_missing(device, "main", capabilities.colorTemperature, capabilities.colorTemperature.colorTemperatureRange.NAME, capabilities.colorTemperature.colorTemperatureRange(value))
63-
end
64-
6557
local aqara_light_handler = {
6658
NAME = "Aqara Light Handler",
6759
lifecycle_handlers = {
68-
init = init,
6960
added = device_added,
7061
doConfigure = do_configure
7162
},

drivers/SmartThings/zigbee-switch/src/test/test_aqara_led_bulb.lua

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ zigbee_test_utils.prepare_zigbee_env_info()
3838

3939
local function test_init()
4040
test.mock_device.add_test_device(mock_device)
41-
test.socket.capability:__expect_send(mock_device:generate_test_message("main", capabilities.colorTemperature.colorTemperatureRange({ minimum = 2700, maximum = 6000 })))
4241
end
4342

4443
test.set_test_init_function(test_init)
@@ -52,7 +51,7 @@ test.register_coroutine_test(
5251
test.socket.zigbee:__expect_send({
5352
mock_device.id, cluster_base.write_manufacturer_specific_attribute(mock_device, PRIVATE_CLUSTER_ID,
5453
PRIVATE_ATTRIBUTE_ID, MFG_CODE, data_types.Uint8, 1) })
55-
-- test.socket.capability:__expect_send(mock_device:generate_test_message("main", capabilities.colorTemperature.colorTemperatureRange({ minimum = 2700, maximum = 6000 })))
54+
test.socket.capability:__expect_send(mock_device:generate_test_message("main", capabilities.colorTemperature.colorTemperatureRange({ minimum = 2700, maximum = 6000 })))
5655
end
5756
)
5857

drivers/SmartThings/zigbee-switch/src/test/test_aqara_light.lua

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ zigbee_test_utils.prepare_zigbee_env_info()
4040

4141
local function test_init()
4242
test.mock_device.add_test_device(mock_device)
43-
test.socket.capability:__expect_send(mock_device:generate_test_message("main", capabilities.colorTemperature.colorTemperatureRange({ minimum = 2700, maximum = 6000 })))
4443
end
4544

4645
test.set_test_init_function(test_init)
@@ -54,7 +53,7 @@ test.register_coroutine_test(
5453
test.socket.zigbee:__expect_send({
5554
mock_device.id, cluster_base.write_manufacturer_specific_attribute(mock_device, PRIVATE_CLUSTER_ID,
5655
PRIVATE_ATTRIBUTE_ID, MFG_CODE, data_types.Uint8, 1) })
57-
-- test.socket.capability:__expect_send(mock_device:generate_test_message("main", capabilities.colorTemperature.colorTemperatureRange({ minimum = 2700, maximum = 6000 })))
56+
test.socket.capability:__expect_send(mock_device:generate_test_message("main", capabilities.colorTemperature.colorTemperatureRange({ minimum = 2700, maximum = 6000 })))
5857
end
5958
)
6059

0 commit comments

Comments
 (0)