Update to Error Prone 2.41.0 (uber#1239)

Almost all the code fixes are for the new
[EffectivelyPrivate](https://errorprone.info/bugpattern/EffectivelyPrivate)
check.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Chores**
  * Updated Error Prone version to 2.41.0 across all environments.
* **Refactor**
* Improved internal code encapsulation by restricting visibility of
constructors, fields, and methods in multiple components without
affecting user-facing functionality.
* **Tests**
* Added test annotation to a suppression suggestion test method for
improved test execution.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: msridhar

.github/workflows/continuous-integration.yml

@@ -25,13 +25,13 @@ jobs:
             epVersion: 2.31.0
           - os: macos-latest
             java: 17
-            epVersion: 2.39.0
+            epVersion: 2.41.0
           - os: windows-latest
             java: 17
-            epVersion: 2.39.0
+            epVersion: 2.41.0
           - os: ubuntu-latest
             java: 17
-            epVersion: 2.39.0
+            epVersion: 2.41.0
       fail-fast: false
     runs-on: ${{ matrix.os }}
     steps:
@@ -60,7 +60,7 @@ jobs:
           ORG_GRADLE_PROJECT_epApiVersion: ${{ matrix.epVersion }}
         run: ./gradlew codeCoverageReport
         continue-on-error: true
-        if: runner.os == 'Linux' && matrix.java == '17' && matrix.epVersion == '2.39.0' && github.repository == 'uber/NullAway'
+        if: runner.os == 'Linux' && matrix.java == '17' && matrix.epVersion == '2.41.0' && github.repository == 'uber/NullAway'
       - name: Upload coverage reports to Codecov
         uses: codecov/codecov-action@v4
         with:

gradle/dependencies.gradle

@@ -19,7 +19,7 @@ import org.gradle.util.VersionNumber
 // The oldest version of Error Prone that we support running on
 def oldestErrorProneVersion = "2.14.0"
 // Latest released Error Prone version that we've tested with
-def latestErrorProneVersion = "2.39.0"
+def latestErrorProneVersion = "2.41.0"
 // Default to using latest tested Error Prone version
 def defaultErrorProneVersion =  latestErrorProneVersion
 def errorProneVersionToCompileAgainst = defaultErrorProneVersion

library-model/library-model-generator/src/main/java/com/uber/nullaway/libmodel/LibraryModelGenerator.java

@@ -192,7 +192,7 @@ private static class AnnotationCollectorCallback implements SourceRoot.Callback
 
     private final AnnotationCollectionVisitor annotationCollectionVisitor;
 
-    public AnnotationCollectorCallback(LibraryModelData modelData) {
+    AnnotationCollectorCallback(LibraryModelData modelData) {
       this.annotationCollectionVisitor = new AnnotationCollectionVisitor(modelData);
     }
 
@@ -220,7 +220,7 @@ private static class AnnotationCollectionVisitor extends VoidVisitorAdapter<Void
     private static final String NULLABLE = "Nullable";
     private static final String JSPECIFY_NULLABLE_IMPORT = "org.jspecify.annotations.Nullable";
 
-    public AnnotationCollectionVisitor(LibraryModelData modelData) {
+    AnnotationCollectionVisitor(LibraryModelData modelData) {
       this.methodRecords = modelData.methodRecords;
       this.nullableUpperBounds = modelData.nullableUpperBounds;
       this.nullMarkedClasses = modelData.nullMarkedClasses;

nullaway/src/main/java/com/uber/nullaway/CodeAnnotationInfo.java

@@ -319,17 +319,17 @@ private boolean isAnnotatedTopLevelClass(
    * key used to retrieve it.
    */
   private static final class ClassCacheRecord {
-    public final Symbol.ClassSymbol outermostClassSymbol;
-    public final boolean isNullnessAnnotated;
-    public final Map<Symbol.MethodSymbol, Boolean> methodNullnessCache;
+    final Symbol.ClassSymbol outermostClassSymbol;
+    final boolean isNullnessAnnotated;
+    final Map<Symbol.MethodSymbol, Boolean> methodNullnessCache;
 
-    public ClassCacheRecord(Symbol.ClassSymbol outermostClassSymbol, boolean isAnnotated) {
+    ClassCacheRecord(Symbol.ClassSymbol outermostClassSymbol, boolean isAnnotated) {
       this.outermostClassSymbol = outermostClassSymbol;
       this.isNullnessAnnotated = isAnnotated;
       this.methodNullnessCache = new HashMap<>();
     }
 
-    public boolean isMethodNullnessAnnotated(Symbol.MethodSymbol methodSymbol) {
+    boolean isMethodNullnessAnnotated(Symbol.MethodSymbol methodSymbol) {
       return methodNullnessCache.computeIfAbsent(
           methodSymbol,
           m -> {

nullaway/src/main/java/com/uber/nullaway/dataflow/AccessPath.java

@@ -647,7 +647,7 @@ private static final class StringMapKey implements MapKey {
 
     private final String key;
 
-    public StringMapKey(String key) {
+    StringMapKey(String key) {
       this.key = key;
     }
 
@@ -669,7 +669,7 @@ private static final class NumericMapKey implements MapKey {
 
     private final long key;
 
-    public NumericMapKey(long key) {
+    NumericMapKey(long key) {
       this.key = key;
     }
 

nullaway/src/main/java/com/uber/nullaway/handlers/ApacheThriftIsSetHandler.java

@@ -115,7 +115,7 @@ private static final class FieldAndGetterElements {
 
     final @Nullable Element getterElem;
 
-    public FieldAndGetterElements(@Nullable Element fieldElem, @Nullable Element getterElem) {
+    FieldAndGetterElements(@Nullable Element fieldElem, @Nullable Element getterElem) {
       this.fieldElem = fieldElem;
       this.getterElem = getterElem;
     }

nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModelsHandler.java

@@ -967,7 +967,7 @@ private static class CombinedLibraryModels implements LibraryModels {
 
     private final ImmutableList<StreamTypeRecord> customStreamNullabilitySpecs;
 
-    public CombinedLibraryModels(Iterable<LibraryModels> models, Config config) {
+    CombinedLibraryModels(Iterable<LibraryModels> models, Config config) {
       this.config = config;
       ImmutableSetMultimap.Builder<MethodRef, Integer> failIfNullParametersBuilder =
           new ImmutableSetMultimap.Builder<>();
@@ -1168,7 +1168,7 @@ private static class NameIndexedMap<T> {
         this.state = state;
       }
 
-      public @Nullable T get(Symbol.MethodSymbol symbol) {
+      @Nullable T get(Symbol.MethodSymbol symbol) {
         Map<MethodRef, T> methodRefTMap = state.get(symbol.name);
         if (methodRefTMap == null) {
           return null;
@@ -1177,7 +1177,7 @@ private static class NameIndexedMap<T> {
         return methodRefTMap.get(ref);
       }
 
-      public boolean nameNotPresent(Symbol.MethodSymbol symbol) {
+      boolean nameNotPresent(Symbol.MethodSymbol symbol) {
         return state.get(symbol.name) == null;
       }
     }
@@ -1192,7 +1192,7 @@ public boolean nameNotPresent(Symbol.MethodSymbol symbol) {
     private final NameIndexedMap<Boolean> nonNullRet;
     private final NameIndexedMap<ImmutableSet<Integer>> castToNonNullMethods;
 
-    public OptimizedLibraryModels(LibraryModels models, Context context) {
+    OptimizedLibraryModels(LibraryModels models, Context context) {
       Names names = Names.instance(context);
       failIfNullParams = makeOptimizedIntSetLookup(names, models.failIfNullParameters());
       explicitlyNullableParams =
@@ -1207,11 +1207,11 @@ public OptimizedLibraryModels(LibraryModels models, Context context) {
       castToNonNullMethods = makeOptimizedIntSetLookup(names, models.castToNonNullMethods());
     }
 
-    public boolean hasNonNullReturn(Symbol.MethodSymbol symbol, Types types, boolean checkSuper) {
+    boolean hasNonNullReturn(Symbol.MethodSymbol symbol, Types types, boolean checkSuper) {
       return lookupHandlingOverrides(symbol, types, nonNullRet, checkSuper) != null;
     }
 
-    public boolean hasNullableReturn(Symbol.MethodSymbol symbol, Types types, boolean checkSuper) {
+    boolean hasNullableReturn(Symbol.MethodSymbol symbol, Types types, boolean checkSuper) {
       return lookupHandlingOverrides(symbol, types, nullableRet, checkSuper) != null;
     }
 

nullaway/src/main/java/com/uber/nullaway/handlers/OptionalEmptinessHandler.java

@@ -308,8 +308,7 @@ private boolean optionalIsGetCall(Symbol.MethodSymbol symbol, Types types) {
    * directly.
    */
   private static final class OptionalContentVariableElement implements VariableElement {
-    public static final Context.Key<OptionalContentVariableElement> contextKey =
-        new Context.Key<>();
+    static final Context.Key<OptionalContentVariableElement> contextKey = new Context.Key<>();
 
     private static final ImmutableSet<Modifier> MODIFIERS =
         ImmutableSet.of(Modifier.PUBLIC, Modifier.FINAL);

nullaway/src/test/java/com/uber/nullaway/AutoSuggestTest.java

@@ -318,7 +318,8 @@ public void suggestCastToNonNullPreserveComments() throws IOException {
         .doTest(TEXT_MATCH);
   }
 
-  public void suggestInitSuppressionOnConstructor() throws IOException {
+  @Test
+  public void suggestInitSuppressionOnConstructor() {
     makeTestHelper()
         .addInputLines(
             "Test.java",