Merge pull request #127 from hafenkran/fix_retry_attach

hafenkran · web-flow · commit 121634eed6fd · 2025-10-26T17:17:52.000+01:00
Allow retrying failed BQ catalog loads
diff --git a/src/storage/bigquery_catalog_set.cpp b/src/storage/bigquery_catalog_set.cpp
@@ -86,8 +86,13 @@ void BigqueryCatalogSet::TryLoadEntries(ClientContext &context) {
         return;
     }
 
-    is_loaded = true;
-    LoadEntries(context);
+    try {
+        LoadEntries(context);
+        is_loaded = true;
+    } catch (...) {
+        is_loaded = false;
+        throw;
+    }
 }
 
 BigqueryInSchemaSet::BigqueryInSchemaSet(BigquerySchemaEntry &schema)

Original file line number	Diff line number	Diff line change
`@@ -86,8 +86,13 @@ void BigqueryCatalogSet::TryLoadEntries(ClientContext &context) {`
`86`	`86`	`return;`
`87`	`87`	`}`
`88`	`88`
`89`		`- is_loaded = true;`
`90`		`- LoadEntries(context);`
	`89`	`+ try {`
	`90`	`+ LoadEntries(context);`
	`91`	`+ is_loaded = true;`
	`92`	`+ } catch (...) {`
	`93`	`+ is_loaded = false;`
	`94`	`+ throw;`
	`95`	`+ }`
`91`	`96`	`}`
`92`	`97`
`93`	`98`	`BigqueryInSchemaSet::BigqueryInSchemaSet(BigquerySchemaEntry &schema)`