Transition to Apache NetBeans core

[Chris2011]

Hey @haidubogdan I saw your PR to the core and would like to thank you for your great effort. I just want to ask for what the progress is? There are some changes requested. Can someone help you here? I also see, that you still commit to this repo here and to a laravel repo.

So just tell me, what are your plans and how we can help here.

Cheers

Chris

[haidubogdan]

Hi Chris,
Unfortunatelly I was a bit busy this period, so I couldn't have a steady progress.

In the end the PR it turned into refactor project to have a good license, code compliance, prepare unit tests ... etc.

I always had issues with the php lexer embedding on a combination of ":" with other character in a enclosed bracket context "()". Ex @test($var ?: 'var') . It's a php editor module issue and I should have created a ticket earlier. But I now that it complex thing to debug.
I had some hacks which were working fine.

But last week I discovered that the freeze is happening on delete action also.

So another setback :) ... I will have to abandon the native php lexer embedding. For which I prepared a solution.

With my current schedule. I hope yo have a stedier pace from 27 september and hope to wrap the PR at the middle of october.

[Chris2011]

Hey @haidubogdan thx for your explanation. I can understand it. I think what will be better is not trying to rebuild the lexer in your plugin and i guess it will help to extend the PHP lexer in the core. I think you have more power for this, Also you can ask junichi, he is very good in the PHP integration and he can help you a lot I guess.

Yes, adding something, which is that big, into the core can be sometimes frustrating but very nice at the end. We all want a stable base :). So just ask for help if you need some and you will get a helping hand...sometimes :D.

Cheers

Chris

[haidubogdan]

Thanks you :),

I did some investigations recently.
And it seems that the lock action might be stuck.

I don't know why it's related with a Php embedded text which has "?:" text in it.

The content of the file was :
@test($xydddyyss ?: $defsss)

This message is when I stop the locked task.

---

java.lang.Error: Interrupted attempt to acquire write lock at java.desktop/javax.swing.text.AbstractDocument.writeLock(AbstractDocument.java:1383) at org.netbeans.editor.BaseDocument.extWriteLock(BaseDocument.java:1702) at org.netbeans.editor.BaseDocument.atomicLockImpl(BaseDocument.java:1751) at org.netbeans.editor.GuardedDocument.runAtomicAsUser(GuardedDocument.java:329) at org.netbeans.editor.BaseKit$DeleteCharAction.actionPerformed(BaseKit.java:2133) at org.netbeans.editor.BaseAction.actionPerformed(BaseAction.java:324) at java.desktop/javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1810) at java.desktop/javax.swing.JComponent.processKeyBinding(JComponent.java:2956) at java.desktop/javax.swing.JComponent.processKeyBindings(JComponent.java:3004) at java.desktop/javax.swing.JComponent.processKeyEvent(JComponent.java:2918) at java.desktop/java.awt.Component.processEvent(Component.java:6393) at java.desktop/java.awt.Container.processEvent(Container.java:2266) at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4991) at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2324) at java.desktop/java.awt.Component.dispatchEvent(Component.java:4823) at java.desktop/java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1952) at java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:883) at java.desktop/java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:1146) at java.desktop/java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:1020) at java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:848) at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4872) at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2324) at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2780) at java.desktop/java.awt.Component.dispatchEvent(Component.java:4823) at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:775) at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:720) at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:714) at java.base/java.security.AccessController.doPrivileged(AccessController.java:399) at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86) at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:97) at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:747) at java.desktop/java.awt.EventQueue$5.run(EventQueue.java:745) at java.base/java.security.AccessController.doPrivileged(AccessController.java:399) at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:86) at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:744) at org.netbeans.core.TimableEventQueue.dispatchEvent(TimableEventQueue.java:136) [catch] at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:203) at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124) at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113) at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109) at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101) at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

[haidubogdan]

I think I found a lead.
PHPBracesMatcher locks the file but when the delete action occurs it doesn't manage to unlock the file.
Maybe a infinite loop? or invalid caret position error.
I will analyze more, and try to see if I can create a ticket for it.

[haidubogdan]

Indeed it's a infinite loop.
In an embedded context it's not existing (id === PhpTokenId.PHP_TOKEN) . (PHP_TOKEN being the '(' paranthesis)

[Chris2011]

Nice catch. Just create a ticket and maybe it will be fixed in the next release :)

[Chris2011]

Heya, if I understand it correctly, when this PR apache/netbeans#7618 is merged, this plugin here and the laravel plugin from you is obsolete, right? I just want to know the progress, I saw that you set another one as a reviewer at the NetBeans repo :)

[haidubogdan]

Unfortunately, it's not up to date, but I think adding new evolution, will block the current PR .
I don't think it will be obsolete 100%, :) in order to be available for older versions of netbeans.
Due to time, I didn't manage to keep up to date the official Netbeans Library blade plugin. (I need to deploy to maven, request validation ... etc) .
So, the version from my repo is always the latest one.

[Chris2011]

Understood and make sense. I just would suggest that the open PR will be handled and managed by you soon, so that the base can be implemented into NetBeans soon. And later, if you think that your plugin has more and more featues, those can then easily tranfered into the core. My opinion.. Thx for your great work.