Skip to content

Commit e480713

Browse files
committed
perf: add control for file view
1 parent 790ec5a commit e480713

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

packages/sdoc-editor/src/extension/toolbar/insert-element-toolbar/index.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ const QuickInsertBlockMenu = ({
4444
const [currentSelectIndex, setCurrentSelectIndex] = useState(-1); // -1 is input focus position
4545
const [quickInsertMenuSearchMap, setQuickInsertMenuSearchMap] = useState(SIDE_QUICK_INSERT_MENUS_SEARCH_MAP);
4646

47+
const enableMetadataManagement = context.getSetting('enableMetadataManagement');
48+
4749
const onInsertImageToggle = useCallback(() => {
4850
callback && callback();
4951
const eventBus = EventBus.getInstance();
@@ -241,7 +243,7 @@ const QuickInsertBlockMenu = ({
241243
onInsertList(ELEMENT_TYPE.ORDERED_LIST);
242244
}} />,
243245
[CHECK_LIST_ITEM]: <DropdownMenuItem isHidden={!quickInsertMenuSearchMap[CHECK_LIST_ITEM]} key="sdoc-insert-menu-check-list" menuConfig={{ ...SIDE_INSERT_MENUS_CONFIG[ELEMENT_TYPE.CHECK_LIST_ITEM] }} onClick={onInsertCheckList} />,
244-
...(editor.editorType === WIKI_EDITOR && {
246+
...(editor.editorType === WIKI_EDITOR && enableMetadataManagement && {
245247
[FILE_VIEW]:
246248
// eslint-disable-next-line react/jsx-indent
247249
<DropdownMenuItem isHidden={!quickInsertMenuSearchMap[FILE_VIEW]} key="sdoc-insert-menu-file-view" menuConfig={{ ...SIDE_INSERT_MENUS_CONFIG[ELEMENT_TYPE.FILE_VIEW] }} className="pr-2">

packages/sdoc-editor/src/extension/toolbar/side-toolbar/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { INTERNAL_EVENT, WIKI_EDITOR } from '../../../constants';
66
import { useScrollContext } from '../../../hooks/use-scroll-context';
77
import { isMobile } from '../../../utils/common-utils';
88
import EventBus from '../../../utils/event-bus';
9-
import { CODE_BLOCK, TABLE, BLOCKQUOTE, CHECK_LIST_ITEM, CALL_OUT, TABLE_DRAG_KEY, LIST_ITEM, MULTI_COLUMN, ORDERED_LIST, UNORDERED_LIST, PARAGRAPH, IMAGE_BLOCK, TWO_COLUMN, VIDEO, WHITEBOARD, FILE_VIEW, FORMULA, COLUMN } from '../../constants';
9+
import { CODE_BLOCK, TABLE, BLOCKQUOTE, CHECK_LIST_ITEM, CALL_OUT, TABLE_DRAG_KEY, LIST_ITEM, MULTI_COLUMN, ORDERED_LIST, UNORDERED_LIST, PARAGRAPH, IMAGE_BLOCK, VIDEO, WHITEBOARD, FILE_VIEW, FORMULA, COLUMN } from '../../constants';
1010
import { findPath, focusEditor } from '../../core';
1111
import { getCalloutEntry } from '../../plugins/callout/helper';
1212
import { insertImageFiles } from '../../plugins/image/helpers';

packages/sdoc-editor/src/extension/toolbar/side-toolbar/insert-block-menu.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ const InsertBlockMenu = ({
3232
}) => {
3333
const editor = useSlateStatic();
3434
const { t } = useTranslation('sdoc-editor');
35+
const enableMetadataManagement = context.getSetting('enableMetadataManagement');
3536

3637
const onInsertImageToggle = useCallback(() => {
3738
const eventBus = EventBus.getInstance();
@@ -166,7 +167,7 @@ const InsertBlockMenu = ({
166167
onInsertList(ELEMENT_TYPE.ORDERED_LIST);
167168
}} />
168169
<DropdownMenuItem isHidden={!insertMenuSearchMap[ELEMENT_TYPE.CHECK_LIST_ITEM]} menuConfig={{ ...SIDE_INSERT_MENUS_CONFIG[ELEMENT_TYPE.CHECK_LIST_ITEM] }} onClick={onInsertCheckList} />
169-
{editor.editorType === WIKI_EDITOR && (
170+
{editor.editorType === WIKI_EDITOR && enableMetadataManagement && (
170171
<DropdownMenuItem isHidden={!insertMenuSearchMap[ELEMENT_TYPE.FILE_VIEW]} key="sdoc-insert-menu-file-view" menuConfig={{ ...SIDE_INSERT_MENUS_CONFIG[ELEMENT_TYPE.FILE_VIEW] }} className="pr-2">
171172
<i className="sdocfont sdoc-arrow-right sdoc-dropdown-item-right-icon"></i>
172173
<LinkRepoPopover onRepoClick={onRepoClick} />

0 commit comments

Comments
 (0)