Akkoma: Authentication raises errors due to `/.well-known/oauth-authorization-server` endpoint call

[thcrt]

cb48c95 added a check to the endpoint /.well-known/oauth-authorization-server. Unfortunately, on Akkoma (and likely Pleroma, though I haven't checked), this endpoint doesn't exist. What's more, instead of returning the status code 404, it instead returns a code of 200 and a body containing the instance's web UI homepage.

This check can be skipped in Mastodon.auth_request_url() by passing skip_server_info=True. However, it's unavoidable when calling Mastodon.log_in(), as well as a few other methods.

I'll submit an issue to the Akkoma tracker as well, since this really shouldn't be happening on their side. But since this currently affects, to my knowledge, all Akkoma servers -- and many may take some time to update -- it might be worth adding a skip_server_info or similar parameter to either the individual methods or to Mastodon.__init__() itself?

[halcy]

:|

I thought I'd accounted for everything in being compatible with other impls when adding that check, because I was worried it would break things, but I did not expect that. Sigh. I'll figure out how to best fix that, I guess. I would like to avoid having an extra parameter, though, maybe I can just wrap it, catch errors as needed, and fall back to previous behaviour, do you think that would work?

[thcrt]

Yeah, I expect so. We'd need to catch MastodonAPIError.

In the error message, I'd check to see it says Could not parse response as JSON, response code was 200, bad json content was (...) and then also contains the text To use Akkoma, please enable JavaScript. or To use Pleroma, please enable JavaScript..

This is a pretty janky solution but if it works, it works. I'm happy to put together a PR in a couple minutes. I still need to complain at the Akkoma people :^)