Fix increasing quota on PUBACK or PUBREC of stray IDs

halfgaar · halfgaar · commit a88a01aea9de · 2026-03-17T21:52:08.000+01:00
diff --git a/session.cpp b/session.cpp
@@ -236,7 +236,7 @@ bool Session::clearQosMessage(uint16_t packet_id, bool qosHandshakeEnds)
         result = true;
     }
 
-    if (qosHandshakeEnds)
+    if (qosHandshakeEnds && result)
     {
         qos_locked->increaseFlowControlQuota();
     }

Original file line number	Diff line number	Diff line change
`@@ -236,7 +236,7 @@ bool Session::clearQosMessage(uint16_t packet_id, bool qosHandshakeEnds)`
`236`	`236`	`result = true;`
`237`	`237`	`}`
`238`	`238`
`239`		`- if (qosHandshakeEnds)`
	`239`	`+ if (qosHandshakeEnds && result)`
`240`	`240`	`{`
`241`	`241`	`qos_locked->increaseFlowControlQuota();`
`242`	`242`	`}`