refactor(scripts): Removed path-exists dependency

path-exists is not reuiqred for synchronous checks in file system, so it was replaced by

fs.existsSync

closes #84

Author: halfzebra

package.json

@@ -60,7 +60,6 @@
     "html-webpack-plugin": "2.24.1",
     "http-proxy-middleware": "^0.17.3",
     "minimist": "1.2.0",
-    "path-exists": "3.0.0",
     "postcss-loader": "1.2.1",
     "prompt": "1.0.0",
     "react-dev-utils": "0.4.2",

scripts/build.js

@@ -2,12 +2,12 @@
 // Suppress warnings if this file is missing.
 require('dotenv').config({silent: true});
 
-const pathExists = require('path-exists');
+const fs = require('fs');
 const chalk = require('chalk');
 const webpack = require('webpack');
 const config = require('../config/webpack.config.prod');
 
-if (pathExists.sync('elm-package.json') === false) {
+if (fs.existsSync('elm-package.json') === false) {
   console.log('Please, run the build script from project root directory');
   process.exit(1);
 }

scripts/create.js

@@ -1,8 +1,7 @@
-const renameSync = require('fs').renameSync;
+const fs = require('fs');
 const copySync = require('fs-extra').copySync;
 const path = require('path');
 const chalk = require('chalk');
-const pathExists = require('path-exists');
 const spawnSync = require('child_process').spawnSync;
 const argv = require('minimist')(process.argv.slice(2));
 const commands = argv._;
@@ -24,11 +23,11 @@ function createElmApp (name) {
   var root = path.resolve(name);
   var template = path.join(__dirname, '../template');
 
-  if (!pathExists.sync(name)) {
+  if (!fs.existsSync(name)) {
 
     try {
       copySync(template, root);
-      renameSync(path.resolve(root, 'gitignore'), path.resolve(root, '.gitignore'));
+      fs.renameSync(path.resolve(root, 'gitignore'), path.resolve(root, '.gitignore'));
     } catch (err) {
       console.log(err);
       process.exit(1);

scripts/eject.js

@@ -2,10 +2,8 @@ const path = require('path');
 const spawn = require('cross-spawn');
 const chalk = require('chalk');
 const extend = require('extend');
-const pathExists = require('path-exists');
 const prompt = require('prompt');
-const fs = require('fs');
-const copySync = require('fs-extra').copySync;
+const fs = require('fs-extra');
 const Table = require('cli-table');
 const Promise = require('bluebird');
 const pkgOwn = require(path.join(__dirname, '../package.json'));
@@ -72,9 +70,9 @@ function promptYesOrNo () {
 function performEject (pkg) {
   // Copy the configuration and start/build scripts.
   try {
-    copySync(path.resolve(__dirname, 'build.js'), './scripts/build.js');
-    copySync(path.resolve(__dirname, 'start.js'), './scripts/start.js');
-    copySync(path.resolve(__dirname, '../config'), './config');
+    fs.copySync(path.resolve(__dirname, 'build.js'), './scripts/build.js');
+    fs.copySync(path.resolve(__dirname, 'start.js'), './scripts/start.js');
+    fs.copySync(path.resolve(__dirname, '../config'), './config');
   } catch (err) {
     console.log(chalk.red('Failed to copy scripts, the error is:\n'));
     console.log(err);
@@ -100,7 +98,6 @@ function performEject (pkg) {
 const unusedDependencies = [
   'cross-spawn',
   'fs-extra',
-  'minimist',
   'cli-table',
   'extend',
   'prompt',
@@ -117,12 +114,12 @@ const scripts = {
   test: 'elm-test'
 };
 
-if (pathExists.sync('elm-package.json') === false) {
+if (fs.existsSync('elm-package.json') === false) {
   console.log('Please, run the eject script from project root directory');
   process.exit(1);
 }
 
-if (pathExists.sync('./package.json') === true) {
+if (fs.existsSync('./package.json') === true) {
   console.log('Found existing package.json');
   var pkgEjected = JSON.parse(fs.readFileSync('./package.json', { encoding: 'utf-8' }));
 

scripts/start.js

@@ -1,5 +1,4 @@
 const fs = require('fs');
-const pathExists = require('path-exists');
 const chalk = require('chalk');
 const webpack = require('webpack');
 const WebpackDevServer = require('webpack-dev-server');
@@ -14,7 +13,7 @@ const httpProxyMiddleware = require('http-proxy-middleware');
 // Suppress warnings if this file is missing.
 require('dotenv').config({silent: true});
 
-if (pathExists.sync('elm-package.json') === false) {
+if (fs.existsSync('elm-package.json') === false) {
   console.log('Please, run the build script from project root directory');
   process.exit(0);
 }

tests/create-elm-app.spec.js

@@ -2,7 +2,7 @@ const path = require('path');
 const expect = require('chai').expect;
 const spawn = require('cross-spawn');
 const dircompare = require('dir-compare');
-const pathExists = require('path-exists');
+const fs = require('fs');
 const rimraf = require('rimraf');
 
 
@@ -22,11 +22,11 @@ describe('Create Elm application with `create-elm-app` command', function () {
   }).timeout(60 * 1000);
 
   it('`' + testAppName + '` should have elm-package.json file', function () {
-    expect(pathExists.sync(path.join(testAppDir, 'elm-package.json'))).to.be.equal(true);
+    expect(fs.existsSync(path.join(testAppDir, 'elm-package.json'))).to.be.equal(true);
   });
 
   it('`' + testAppName + '` should have .gitignore file', function () {
-    expect(pathExists.sync(path.join(testAppDir, '.gitignore'))).to.be.equal(true);
+    expect(fs.existsSync(path.join(testAppDir, '.gitignore'))).to.be.equal(true);
   });
 
   it('`' + testAppName + '` should have the same file structure as template', function () {

tests/elm-app.build.spec.js

@@ -2,7 +2,6 @@ const fs = require('fs');
 const path = require('path');
 const spawn = require('cross-spawn');
 const rimraf = require('rimraf');
-const pathExists = require('path-exists');
 const expect = require('chai').expect;
 
 
@@ -36,7 +35,7 @@ describe('Building Elm application with `elm-app build`', function () {
     }).join('');
     expect(result.status).to.be.equal(0, 'Incorrect exit status code');
     expect(outputString).to.have.string('build is ready in `dist/`');
-    expect(pathExists.sync(path.join(testAppDir, 'dist'))).to.be.equal(true);
+    expect(fs.existsSync(path.join(testAppDir, 'dist'))).to.be.equal(true);
   }).timeout(12 * 60 * 1000);
 
   it('`elm-app build` should exit with non zero status code when build failed', function () {

tests/elm-app.eject.spec.js

@@ -3,7 +3,6 @@ const path = require('path');
 const expect = require('chai').expect;
 const spawn = require('cross-spawn');
 const dircompare = require('dir-compare');
-const pathExists = require('path-exists');
 const rimraf = require('rimraf');
 
 
@@ -54,9 +53,9 @@ describe('Ejecting Elm application. (Please wait...)', function () {
   });
 
   it('Ejected application should have build and start scripts', function () {
-    expect(pathExists.sync(path.join(testAppDir, './scripts/build.js')))
+    expect(fs.existsSync(path.join(testAppDir, './scripts/build.js')))
       .to.be.equal(true);
-    expect(pathExists.sync(path.join(testAppDir, './scripts/start.js')))
+    expect(fs.existsSync(path.join(testAppDir, './scripts/start.js')))
       .to.be.equal(true);
   });